[Bug Fix] Render fragment for empty Discriminator Tabs children #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

blindaa121 merged 1 commit into main from frontend/discriminator-tab-bug-fix

Mar 7, 2025

Merged

[Bug Fix] Render fragment for empty Discriminator Tabs children #1099

blindaa121 merged 1 commit into main from frontend/discriminator-tab-bug-fix

Mar 7, 2025

Conversation

@blindaa121

Copy link

Collaborator

@blindaa121 blindaa121 commented Feb 28, 2025

Description

This PR addresses the following issue for page crashes due to non-rendering TabItem components:

image

Motivation and Context

See #1086 for context.

How Has This Been Tested?

Tested with example spec provided in #1086 and navigating to /get-series-list path.

Screenshots (if appropriate)

image

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes if appropriate.
All new and existing tests passed.

@blindaa121


 Return fragment for empty discriminator tab children

28b0ca8

@blindaa121 blindaa121 requested a review from sserrata

February 28, 2025 23:48

@github-actions

Copy link

github-actions bot commented Feb 28, 2025

Size Change: -11.1 kB (-0.55%)

Total Size: 2 MB

Filename	Size	Change
`demo/build/petstore/schemas/cat/index.html`	34.9 kB	-1.92 kB (-5.22%)	✅
`demo/build/petstore/schemas/dog/index.html`	35.2 kB	-2.07 kB (-5.57%)	✅
`demo/build/petstore/schemas/honeybee/index.html`	35.2 kB	-2.04 kB (-5.48%)	✅
`demo/build/petstore/schemas/pet/index.html`	34.2 kB	-2.53 kB (-6.89%)	✅
`demo/build/petstore/schemas/user/index.html`	42.3 kB	-2.53 kB (-5.64%)	✅

i️ View Unchanged

Filename	Size
`demo/.docusaurus/codeTranslations.json`	2 B
`demo/.docusaurus/docusaurus.config.mjs`	13.9 kB
`demo/.docusaurus/globalData.json`	40.7 kB
`demo/.docusaurus/i18n.json`	267 B
`demo/.docusaurus/registry.js`	59.9 kB
`demo/.docusaurus/routes.js`	55.4 kB
`demo/.docusaurus/routesChunkNames.json`	23 kB
`demo/.docusaurus/site-metadata.json`	1.35 kB
`demo/build/assets/css/styles.********.css`	146 kB
`demo/build/assets/js/main.********.js`	672 kB
`demo/build/assets/js/runtime~main.********.js`	15.8 kB
`demo/build/index.html`	91.1 kB
`demo/build/petstore/add-pet/index.html`	27.5 kB
`demo/build/petstore/create-user/index.html`	21.6 kB
`demo/build/petstore/create-users-with-array-input/index.html`	21.6 kB
`demo/build/petstore/create-users-with-list-input/index.html`	21.6 kB
`demo/build/petstore/delete-order/index.html`	21.6 kB
`demo/build/petstore/delete-pet/index.html`	21.7 kB
`demo/build/petstore/delete-user/index.html`	21.9 kB
`demo/build/petstore/find-pets-by-status/index.html`	22.3 kB
`demo/build/petstore/find-pets-by-tags/index.html`	23 kB
`demo/build/petstore/get-inventory/index.html`	20.9 kB
`demo/build/petstore/get-order-by-id/index.html`	21.9 kB
`demo/build/petstore/get-pet-by-id/index.html`	22.5 kB
`demo/build/petstore/get-user-by-name/index.html`	22 kB
`demo/build/petstore/login-user/index.html`	22.5 kB
`demo/build/petstore/logout-user/index.html`	21.3 kB
`demo/build/petstore/new-pet/index.html`	21.9 kB
`demo/build/petstore/pet/index.html`	23.6 kB
`demo/build/petstore/place-order/index.html`	21.1 kB
`demo/build/petstore/schemas/apiresponse/index.html`	22.9 kB
`demo/build/petstore/schemas/category/index.html`	24 kB
`demo/build/petstore/schemas/id/index.html`	21 kB
`demo/build/petstore/schemas/order/index.html`	25.1 kB
`demo/build/petstore/schemas/tag/index.html`	22.4 kB
`demo/build/petstore/store/index.html`	21.6 kB
`demo/build/petstore/subscribe-to-the-store-events/index.html`	27.9 kB
`demo/build/petstore/swagger-petstore-yaml/index.html`	28 kB
`demo/build/petstore/update-pet-with-form/index.html`	21.8 kB
`demo/build/petstore/update-pet/index.html`	22.3 kB
`demo/build/petstore/update-user/index.html`	21.9 kB
`demo/build/petstore/upload-file/index.html`	21.7 kB
`demo/build/petstore/user/index.html`	22.5 kB