-
-
Notifications
You must be signed in to change notification settings - Fork 89
Squiz/DisallowMultipleAssignments: remove irrelevant token #1293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrfnl
merged 1 commit into
4.x
from
feature/squiz-disallowmultipleassignments-minor-tweak
Oct 17, 2025
Merged
Squiz/DisallowMultipleAssignments: remove irrelevant token #1293
jrfnl
merged 1 commit into
4.x
from
feature/squiz-disallowmultipleassignments-minor-tweak
Oct 17, 2025
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `foreach()` loop straight after this bit of code checks for parenthesis owners, but `T_CASE` is not a token which can be marked as a parenthesis owner, so will never match.
@jrfnl
jrfnl
deleted the
feature/squiz-disallowmultipleassignments-minor-tweak
branch
October 17, 2025 02:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
foreach()loop straight after this bit of code checks for parenthesis owners, butT_CASEis not a token which can be marked as a parenthesis owner, so will never match.Suggested changelog entry
N/A (clean up, should make no functional difference)