-
-
Couldn't load subscription status.
- Fork 89
.gitattributes: export ignore some test fixtures #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jrfnl
merged 1 commit into
3.x
from
feature/gitattributes-dont-include-problematic-test-fixtures
Oct 5, 2025
Merged
.gitattributes: export ignore some test fixtures #1288
jrfnl
merged 1 commit into
3.x
from
feature/gitattributes-dont-include-problematic-test-fixtures
Oct 5, 2025
+14
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the test fixtures introduced for testing the `Ruleset` class cause issues with PHPUnit on some versions, in particular the test fixtures involving standards in hidden directories. While the decision was taken long ago to not `export-ignore` the tests until PHPCS 4.0, I'm now taking the executive decision to selective `export-ignore` the problematic test fixtures only on the 3.x branch already to unblock projects which were seeing these errors (like the Composer Installer plugin).
@jrfnl
jrfnl
force-pushed
the
feature/gitattributes-dont-include-problematic-test-fixtures
branch
from
October 5, 2025 00:01
81d8e01 to
9fbd708
Compare
@jrfnl
jrfnl
deleted the
feature/gitattributes-dont-include-problematic-test-fixtures
branch
October 5, 2025 00:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some of the test fixtures introduced for testing the
Rulesetclass cause issues with PHPUnit on some versions, in particular the test fixtures involving standards in hidden directories.While the decision was taken long ago to not
export-ignorethe tests until PHPCS 4.0, I'm now taking the executive decision to selectiveexport-ignorethe problematic test fixtures only on the 3.x branch already to unblock projects which were seeing these errors (like the Composer Installer plugin).Suggested changelog entry
N/A