Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Squiz/MemberVarSpacing: update for properties with asymmetric visibility #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

@jrfnl
Copy link
Member

@jrfnl jrfnl commented Jun 6, 2025
edited
Loading

Description

Allow for the sniff to calculate the "lines before" correctly when asym visibility is used

Includes tests.

Suggested changelog entry

  • Added support for PHP 8.4 asymmetric visibility modifiers to the following sniffs:
    • Squiz.WhiteSpace.MemberVarSpacing

Related issues/external references

Follow up on #851
Follow up on #1116

Related to #734

@jrfnl jrfnl added this to the 3.13.1 milestone Jun 6, 2025
@jrfnl jrfnl mentioned this pull request Jun 6, 2025
47 tasks
Base automatically changed from php-8.4/feature/file-methods-support-asym-visibility to master June 9, 2025 01:45
@jrfnl jrfnl marked this pull request as ready for review June 9, 2025 01:55
Allow for the sniff to calculate the "lines before" correctly when asym visibility is used
Includes tests.
@jrfnl jrfnl force-pushed the php-8.4/feature/squiz-membervarspacing-support-asym-visibility branch from 99ffbdb to f4d7fdd Compare June 9, 2025 03:56
Copy link
Member Author

jrfnl commented Jun 9, 2025

Rebased without changes to get a proper build.

@jrfnl jrfnl merged commit 30d1a16 into master Jun 9, 2025
62 checks passed
@jrfnl jrfnl deleted the php-8.4/feature/squiz-membervarspacing-support-asym-visibility branch June 9, 2025 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

3.13.1

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /