Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(kotlin): Redefined Vars of parent are marked inherited. #22219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sylvain-maillard wants to merge 2 commits into OpenAPITools:master
base: master
Choose a base branch
Loading
from Sylvain-maillard:fix_issue22216-vars-override-missing

Conversation

@Sylvain-maillard
Copy link

@Sylvain-maillard Sylvain-maillard commented Oct 23, 2025

Redefined vars should be marked as inherited so that override modifier is added on children class.

Changes where done in org.openapitools.codegen.languages.AbstractKotlinCodegen#fromModel by adding redefined vars to the map of vars that will be marked as inherited when the model has a parent.

Validated with a Test in org.openapitools.codegen.kotlin.KotlinClientCodegenModelTest

cc @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) 😊

Closes #22216

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Copy link
Member

wing328 commented Oct 28, 2025

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Sylvain-maillard reacted with thumbs up emoji

Copy link
Contributor

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sylvain-maillard reacted with thumbs up emoji
Copy link
Author

Sylvain-maillard commented Oct 28, 2025
edited
Loading

Hi @wing328 and @e5l , thanks for your remarks, I've changed my email address so it should fix the commit issue...

It seems that there is a problem with the CI with this test : GlobalSettingsTest.testNonStringSystemProperties, but I see that it should be disabled. Should I do something about that test ? (I see that the test is marked @disabled which is a Junit annotation, where the test uses the TestNG framework... maybe this is an issue ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@e5l e5l e5l approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] [Kotlin] overriden variables are not generated with 'override' keyword

AltStyle によって変換されたページ (->オリジナル) /