-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
fix(kotlin): Redefined Vars of parent are marked inherited. #22219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kotlin): Redefined Vars of parent are marked inherited. #22219
Conversation
...rride modifier is added on children class. closes OpenAPITools#22216
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.
Let me know if you need help fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hi @wing328 and @e5l , thanks for your remarks, I've changed my email address so it should fix the commit issue...
It seems that there is a problem with the CI with this test : GlobalSettingsTest.testNonStringSystemProperties, but I see that it should be disabled. Should I do something about that test ? (I see that the test is marked @disabled which is a Junit annotation, where the test uses the TestNG framework... maybe this is an issue ?)
Redefined vars should be marked as inherited so that
overridemodifier is added on children class.Changes where done in
org.openapitools.codegen.languages.AbstractKotlinCodegen#fromModelby adding redefined vars to the map of vars that will be marked as inherited when the model has a parent.Validated with a Test in
org.openapitools.codegen.kotlin.KotlinClientCodegenModelTestcc @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06) @e5l (2024/10) 😊
Closes #22216
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)