-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
Update TS Angular v17, v18 tests with the correct versions #22154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
+19,346
−12,027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@wing328
wing328
changed the title
(削除) update ts angualr v17 tests with the correct versions (削除ここまで)
(追記) Update TS Angualr v17, v18, v20 tests with the correct versions (追記ここまで)
Oct 16, 2025
@wing328
wing328
changed the title
(削除) Update TS Angualr v17, v18, v20 tests with the correct versions (削除ここまで)
(追記) Update TS Angular v20 tests with the correct versions (追記ここまで)
Oct 16, 2025
@wing328
wing328
changed the title
(削除) Update TS Angular v20 tests with the correct versions (削除ここまで)
(追記) Update TS Angular v17, v18 tests with the correct versions (追記ここまで)
Oct 16, 2025
6 tasks
will put this on hold unless someone has time to fix it by updating the tests to work with older versions of angular (v17, v18)
given that v18 was release 1 year ago ((May 2024), this change is not something with the highest priority but still we welcome PR to fix the tests to work older versions of Angular.
here is the (partial) error message in case the logs are deleted later:
Chrome Headless 140.0.0.0 (Linux 0.0.0): Executed 17 of 23 SUCCESS (0 secs / 0.044 secs)
Chrome Headless 140.0.0.0 (Linux 0.0.0) AppComponent constructor() should have a userService provided FAILED
Error: Unexpected directive 'AppComponent' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.
at verifySemanticsOfNgModuleImport (node_modules/@angular/core/fesm2022/core.mjs:28987:19)
at forEach (node_modules/@angular/core/fesm2022/core.mjs:28884:9)
at Array.forEach (<anonymous>)
at verifySemanticsOfNgModuleDef (node_modules/@angular/core/fesm2022/core.mjs:28883:60)
at DynamicTestModule.get (node_modules/@angular/core/fesm2022/core.mjs:28836:30)
at TestBedCompiler.applyProviderOverridesInScope (node_modules/@angular/core/fesm2022/testing.mjs:1173:33)
at TestBedCompiler.compileTestModule (node_modules/@angular/core/fesm2022/testing.mjs:1477:14)
at TestBedCompiler.finalize (node_modules/@angular/core/fesm2022/testing.mjs:998:14)
at TestBedImpl.testModuleRef (node_modules/@angular/core/fesm2022/testing.mjs:2010:49)
at TestBedImpl.inject (node_modules/@angular/core/fesm2022/testing.mjs:1914:29)
Chrome Headless 140.0.0.0 (Linux 0.0.0): Executed 18 of 23 (1 FAILED) (0 secs / 0.08 secs)
Chrome Headless 140.0.0.0 (Linux 0.0.0) AppComponent constructor() should have a userService provided FAILED
Error: Unexpected directive 'AppComponent' imported by the module 'DynamicTestModule'. Please add an @NgModule annotation.
at verifySemanticsOfNgModuleImport (node_modules/@angular/core/fesm2022/core.mjs:28987:19)
at forEach (node_modules/@angular/core/fesm2022/core.mjs:28884:9)
at Array.forEach (<anonymous>)
at verifySemanticsOfNgModuleDef (node_modules/@angular/core/fesm2022/core.mjs:28883:60)
at DynamicTestModule.get (node_modules/@angular/core/fesm2022/core.mjs:28836:30)
at TestBedCompiler.applyProviderOverridesInScope (node_modules/@angular/core/fesm2022/testing.mjs:1173:33)
at TestBedCompiler.compileTestModule (node_modules/@angular/core/fesm2022/testing.mjs:1477:14)
at TestBedCompiler.finalize (node_modules/@angular/core/fesm2022/testing.mjs:998:14)
at TestBedImpl.testModuleRef (node_modules/@angular/core/fesm2022/testing.mjs:2010:49)
at TestBedImpl.inject (node_modules/@angular/core/fesm2022/testing.mjs:1914:29)
Chrome Headless 140.0.0.0 (Linux 0.0.0) AppComponent constructor() should have a storeService provided FAILED
if its too much work, i would simply abandon all tests for angular < 20 or 19, just make sure the most up to date version still has tests
right. let's see if there're any "demands" for angular v17, v18 in particular.
if none, we will drop these tests later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)