This repository was archived by the owner on Apr 1, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 227
Support Boostrap 4 in settings menu #87
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltere
commented
Mar 14, 2018
I would also prefer a bootstrap4 compatible version, as I do not want to depend on old bootstrap3 for new projects, as well as I understand that bootstrap3 is still in use by many projects.
make a different branch (bs4) would be better?
It seems like this could be supported by adding a named/scoped slot, so that HeaderSettings could be turned off and an alternate implementation could be provided using whatever ui framework the user chooses, for example:
<div v-if="$slots.default || $slots['customHeaderSettings'] || HeaderSettings" class="clearfix" style="margin-bottom: 10px"> <header-settings v-if="HeaderSettings" class="pull-right" :columns="columns" :support-backup="supportBackup"> </header-settings> <slot /> <slot name="customHeaderSettings" :columns="columns" :support-backup="supportBackup" </slot> </div> JsFiddle showing how a template could be provided in the named/scoped slot: https://jsfiddle.net/g5oc1rgq/128/
maltere
added a commit
to maltere/vue2-datatable
that referenced
this pull request
Apr 2, 2018
This Fork is going to be a Bootstrap 4 solution. This merge is going to add Bootstrap 4 compatability. Maybe there has to be some more changes to the src. Proposed in OneWayTech#87
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.