-
-
Notifications
You must be signed in to change notification settings - Fork 643
initial commit of custom menu inside a code-block #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vaddisrinivas
wants to merge
1
commit into
NotionX:master
from
vaddisrinivas:add-codeblock-menu-options
Open
initial commit of custom menu inside a code-block #545
vaddisrinivas
wants to merge
1
commit into
NotionX:master
from
vaddisrinivas:add-codeblock-menu-options
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Notion is a great tool for note-taking, and writing in general.
react-notion-xadds a lot more to it by essentially making notion as a CMS in a sense. While havingreadersis the core-idea, making it more interactive can help improve learning experiences of people using it. This PR makes an attempt to do the same by addingmenuand assign custom actions assignable from inside theCodecomponent and can be extended to other components as well.This can make the code component do a lot more -
Examples
Python(if bundled with Pyodide),Javascript, making the blogging more interactiveMDXor relatedWhile the current state of this PR is at its infancy, idea of creating this PR is to know if the community finds this helpful and to extend beyond this skeleton
Notion Test Page ID
0c322c33381c49bca5083a451c334c39
Since there is no way to test this unless hosted, I am adding screenshots -
Screenshot 2024年03月17日 at 11 05 58 PM
When the
Menubutton is clicked it logs content and other params inconsole