Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

initial commit of custom menu inside a code-block #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaddisrinivas wants to merge 1 commit into NotionX:master
base: master
Choose a base branch
Loading
from vaddisrinivas:add-codeblock-menu-options

Conversation

@vaddisrinivas
Copy link

@vaddisrinivas vaddisrinivas commented Mar 18, 2024
edited
Loading

Description

Notion is a great tool for note-taking, and writing in general. react-notion-x adds a lot more to it by essentially making notion as a CMS in a sense. While having readers is the core-idea, making it more interactive can help improve learning experiences of people using it. This PR makes an attempt to do the same by adding menu and assign custom actions assignable from inside the Code component and can be extended to other components as well.

This can make the code component do a lot more -

Examples

  • an online interpreter for Python (if bundled with Pyodide), Javascript , making the blogging more interactive
  • an online presentation tool when bundled with MDX or related
  • anything that can run on-browser! can be included and this will do the magic!

While the current state of this PR is at its infancy, idea of creating this PR is to know if the community finds this helpful and to extend beyond this skeleton

Notion Test Page ID

0c322c33381c49bca5083a451c334c39

Since there is no way to test this unless hosted, I am adding screenshots -
Screenshot 2024年03月17日 at 11 05 58 PM

When the Menu button is clicked it logs content and other params in console

Copy link

vercel bot commented Mar 18, 2024
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-notion-x ✅ Ready (Inspect) Visit Preview Mar 18, 2024 3:10am
react-notion-x-minimal-demo ✅ Ready (Inspect) Visit Preview Mar 18, 2024 3:10am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /