-
-
Notifications
You must be signed in to change notification settings - Fork 643
Make checkbox style closer to notion's #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FranciscoMoretti
wants to merge
1
commit into
NotionX:master
from
FranciscoMoretti:refine-checkbox-style
Open
Make checkbox style closer to notion's #357
FranciscoMoretti
wants to merge
1
commit into
NotionX:master
from
FranciscoMoretti:refine-checkbox-style
+36
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
One of the builds fail, I'm not able to see the details in Vercel. When I click details it takes me to a 404 page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make checkbox style match notion's in the aspects described in this issue #356.
The checkbox visuals are a bit inconsistent with an official notion page.
Notion Test Page ID
Comparison:
from react-notion-x vertical
from_react_notion_x_verticalFrom notion.so vertical
from_notion_so_verticalNew checkbox vertical
new_checkbox_verticalEach individual image with the link to the test page:
From minimal example react-notion-x page
https://react-notion-x-demo.transitivebullsh.it/38fa73d49b8f40aab1f3f8c82332e518
from_react_notion_x
From notion.so example page
https://www.notion.so/Checklists-38fa73d49b8f40aab1f3f8c82332e518
from_notion_so
Nex checkboxes in minimal example react-notion-x page
(tested locally)
new_checkbox