-
-
Notifications
You must be signed in to change notification settings - Fork 240
refactor(router): Implement page navigation with RouteReuseStrategy (#949) #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ghost
ghost
assigned
vakrilov
Sep 4, 2017
@ghost
ghost
added
the
in progress
label
Sep 4, 2017
@vakrilov
vakrilov
force-pushed
the
route-reuse-strategy
branch
2 times, most recently
from
September 4, 2017 13:01
ab952e0 to
497f56d
Compare
sis0k0
sis0k0
approved these changes
Sep 7, 2017
@sis0k0
sis0k0
force-pushed
the
route-reuse-strategy
branch
from
September 7, 2017 13:13
d8302c4 to
85e4e35
Compare
@ghost
ghost
assigned
sis0k0
Sep 7, 2017
@ghost
ghost
removed
the
in progress
label
Sep 7, 2017
jogboms
commented
Sep 10, 2017
Thanks @vakrilov. This fixed the clearHistory issue. 👍
jogboms
commented
Sep 10, 2017
JS: ERROR Error: Uncaught (in promise): Error: Currently not in page back navigation - component should be detached instead of deactivated.
JS: Error: Currently not in page back navigation - component should be detached instead of deactivated.
JS: at PageRouterOutlet.deactivate (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/nativescript-angular/router/page-router-outlet.js:134:19) [angular]
JS: at ActivateRoutes.deactivateRouteAndOutlet (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4544:32) [angular]
JS: at ActivateRoutes.deactivateRouteAndItsChildren (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4514:18) [angular]
JS: at ActivateRoutes.deactivateRoutes (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4500:22) [angular]
JS: at file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4466:19 [angular]
JS: at Array.forEach (native) [angular]
JS: at ActivateRoutes.deactivateChildRoutes (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4464:29) [angular]
JS: at ActivateRoutes.activate (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4450:14) [angular]
JS: at file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/@angular/router/bundles/router.umd.js:4064:22 [angular]
JS: at SafeSubscriber._next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Observable.js:224:21) [angular]
JS: at SafeSubscriber.__tryOrSetError (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:247:16) [angular]
JS: at SafeSubscriber.next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:187:27) [angular]
JS: at Subscriber._next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:125:26) [angular]
JS: at Subscriber.next (file:///data/data/com.rfnl.fixershubclient/files/app/tns_modules/rxjs/Subscriber.js:89:18) [angular]
Any particular reason why i would be getting this for a forward navigation?
"@angular/router": "^4.2.6",
"nativescript-angular": "^4.3.0-2017年9月7日-3",
"tns-core-modules": "^3.2.0",
There is a problem with the new routing-strategy when using lazy-modules. We will be looking into this in a next few days. Hopefully there will be another patch soon.
jogboms
commented
Sep 11, 2017
via email
Thanks. Would be looking forward to this.
... On Sep 11, 2017 9:06 PM, "Alexander Vakrilov" ***@***.***> wrote:
There is a problem with the new routing-strategy when using lazy-modules.
We will be looking into this in a next few days. Hopefully there will be
another patch soon.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#977 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AF675nBn23OpbbKep3LCI_E7UodqAGSLks5shZK7gaJpZM4PL4ov>
.
sis0k0
added a commit
that referenced
this pull request
Sep 14, 2017
sis0k0
added a commit
that referenced
this pull request
Sep 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Use
RouteReuseStrategyimplementation to do page navigation with<page-router-outlet>