Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Angular 4.0 support for modules 3.0 #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hdeshev merged 39 commits into master from ng-4.0
Mar 28, 2017
Merged

Angular 4.0 support for modules 3.0 #723

hdeshev merged 39 commits into master from ng-4.0
Mar 28, 2017

Conversation

@hdeshev
Copy link
Contributor

@hdeshev hdeshev commented Mar 28, 2017

No description provided.

sis0k0 added 30 commits March 28, 2017 12:57
... OpaqueToken
COMPILER_OPTIONS is no longer of type OpaqueToken. It is now an InjectionToken parameterized with object with property of type ViewEncapsulation. Introduced by: https://github.com/mhevery/angular/blame/e8778e59231f1a0f37f0ea847a6256398386fa41/tools/public_api_guard/core/index.d.ts#L224-L229 
Needed in order to implement correctly the AnimationPlayer interface.
Introduced by: angular/angular@4577b7c 
COMPILER_OPTIONS now has a property of type MissingTranslationStrategy,
which needs to be imported.
Introduced by: https://github.com/angular/angular/blame/master/tools/public_api_guard/core/index.d.ts#L257 
- Use RendererFactoryV2 instead of RootRenderer
(NativeScriptRendererFactory)
- Use RendererV2 for NativeScriptRenderer
Placeholders.
- createComment - create new element "Comment" using ui/placeholder and
attach it. These comments are used as anchors (nextSibling) for structural directives such as *ngIf and *ngFor.
- createText - create new element "DetachedText" using ui/placeholder
and don't attach it.
BREAKING CHANGE: To use animations, you need to import the
NativeScriptAnimationsModule from "nativescript-angular/animations" in
your root NgModule.
sis0k0 and others added 9 commits March 28, 2017 15:57
No longer using "template" elements, but #comment nodes.
Platform attributes (such as :ios and :android) are passed as
namespaces to the renderer in Angular 4.
Caused by: angular/angular#14874.
...718)
setAttribute is now called on createElement instead of appendChild when
using EmulatedRenderer.
Copy link
Contributor

sis0k0 commented Mar 28, 2017

:shipit:

danielgek reacted with laugh emoji

@hdeshev hdeshev merged commit fa089aa into master Mar 28, 2017
@hdeshev hdeshev deleted the ng-4.0 branch March 28, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sis0k0 sis0k0 sis0k0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /