Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Support Angular RC5 #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hdeshev merged 25 commits into master from hdeshev/ng-rc5
Aug 30, 2016
Merged

Support Angular RC5 #405

hdeshev merged 25 commits into master from hdeshev/ng-rc5
Aug 30, 2016

Conversation

@hdeshev
Copy link
Contributor

@hdeshev hdeshev commented Aug 19, 2016
edited
Loading

The Mother of All Pull Requests!

  • Migrate to Angular 2 RC5.
  • Bootstrapping apps now done with NgModule's. The old nativescriptBootstrap method is gone, and apps should switch to the platformNativeScriptDynamic().bootstrapModule(MyAppModule) API. Yes, ALL CLIENT APPS NEED TO BE CHANGED
  • The library entrypoint is now the nativescript-angular/platform module. Import NativeScriptRouterModule from nativescript-angular/router and NativeScriptFormsModule from nativescript-angular/forms respectively if you want to use routing and form value accessor directives.
  • Remove all traces of router-deprecated.

Known Issues

  • Karma test runner almost always hangs on Travis (yes, again!)
  • tests/app/tests/snippets.ts test never raises router NavigationStart event.

Ping @nsndeck, @vakrilov

NathanWalker, vakrilov, gergderkson, and acramatte reacted with thumbs up emoji NathanWalker, vietanhdev, and gergderkson reacted with hooray emoji NathanWalker reacted with heart emoji
Copy link
Contributor Author

hdeshev commented Aug 19, 2016

I published the package to npm as version 0.4.0-beta1 under the angular2-rc5, so people could try it out easily :)

NathanWalker, triniwiz, and jlooper reacted with thumbs up emoji NathanWalker and triniwiz reacted with heart emoji

Copy link
Contributor

nsndeck commented Aug 19, 2016

👍

1 similar comment
Copy link
Contributor

👍

Copy link

mko commented Aug 26, 2016

Any idea when this will be integrated?

Copy link
Contributor

@hdeshev I was able to use the 0.4.0-beta1 tag to update https://github.com/NathanWalker/angular2-seed-advanced to rc.5 and it works great.
Thank you for that 👍

@hdeshev hdeshev force-pushed the hdeshev/ng-rc5 branch 3 times, most recently from 9b027ed to 7dd4b0e Compare August 30, 2016 13:03
hdeshev added 21 commits August 30, 2016 16:03
Fix compile errors in http and style-properties examples
nativescript-angular/platform is the new cool thing.
@hdeshev hdeshev merged commit 20120f2 into master Aug 30, 2016
@sis0k0 sis0k0 deleted the hdeshev/ng-rc5 branch August 3, 2017 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /