-
-
Notifications
You must be signed in to change notification settings - Fork 240
Added animations support in Angular 2 RC3 #303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (this.animation && this.animation.isPlaying) {
this.animation.cancel();
}
// TODO: apply end values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: apply end values ?
Couple of comments about the examples inside ng-sample:
nativeScriptBootstrap(AnimationKeyframesTest)- doesn't show anything - both iOS and AndroidnativeScriptBootstrap(AnimationEnterLeaveTest)- taping on on of the items causes a crash - both iOS and AndroidnativeScriptBootstrap(AnimationEnterLeaveTest)- theenteranimation doesn't seem to trigger on iOSnativeScriptBootstrap(AnimationStatesTest);- on Android - when triggering the animation the button background changes to white first and then form white to red/green
@tzraikov
tzraikov
force-pushed
the
raikov/animations-rc3
branch
5 times, most recently
from
July 6, 2016 08:36
4809afc to
2bd2d16
Compare
@tzraikov
tzraikov
force-pushed
the
raikov/animations-rc3
branch
from
July 6, 2016 12:13
2bd2d16 to
4b70a7e
Compare
👍
brace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.