-
-
Notifications
You must be signed in to change notification settings - Fork 240
PageRouterOutlet for @angular/router v.3 #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@vakrilov
vakrilov
force-pushed
the
router-3
branch
4 times, most recently
from
June 17, 2016 15:21
9aa665b to
f786218
Compare
@vakrilov
vakrilov
force-pushed
the
router-3
branch
from
June 20, 2016 08:37
f786218 to
5a440a1
Compare
Shouldn't we use the new router instead of the deprecated one in the E2E tests?
Other than that 💯
@vakrilov
vakrilov
force-pushed
the
router-3
branch
from
June 21, 2016 10:35
3d6e884 to
f285889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #218