Skip to content

fix(router): Link active directive: fix adding CSS class #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

NathanWalker merged 1 commit into NativeScript:master from denlysenko:fix/ns-router-link-active

Aug 19, 2020

Merged

fix(router): Link active directive: fix adding CSS class #2227

NathanWalker merged 1 commit into NativeScript:master from denlysenko:fix/ns-router-link-active

Aug 19, 2020

Conversation

Copy link

Contributor

@denlysenko denlysenko commented Aug 19, 2020

fixes #2224


 fix(router): link active directive

a48b162

Copy link

cla-bot bot commented Aug 19, 2020

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla.
CLA has not been signed by users: @denlysenko.
After signing the CLA, you can ask me to recheck this PR by posting @cla-bot check as a comment to the PR.

Copy link

Contributor Author

denlysenko commented Aug 19, 2020

Copy link

cla-bot bot commented Aug 19, 2020

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot bot added the cla: yes label

@NathanWalker NathanWalker merged commit 5e165b5 into NativeScript:master

Copy link

Contributor

NathanWalker commented Aug 19, 2020

Thanks @denlysenko this is published in 10.0.2 now 👍

@denlysenko denlysenko deleted the fix/ns-router-link-active branch

September 1, 2020 19:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants

@denlysenko @NathanWalker