Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Upgrade to Angular RC0 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hdeshev merged 5 commits into master from hdeshev/angular-rc0
May 4, 2016
Merged

Upgrade to Angular RC0 #213

hdeshev merged 5 commits into master from hdeshev/angular-rc0
May 4, 2016

Conversation

@hdeshev
Copy link
Contributor

@hdeshev hdeshev commented May 4, 2016

Lots of changes all over the place due to changed package names.

Notable hacks:

  • global.window = global to avoid a crash when creating a platform.
  • DetachedLoader loads components by resolving promises after its ngAfterViewInit callback fires.
  • disabled router tests due to (my guess) an obscure issue causing lifecycle callbacks like ngOnInit and ngAfterViewInit not to be called in the test app. We'll probably have to migrate those tests to a separate Appium-based project

Fixes #207

matt4446 reacted with hooray emoji
@hdeshev hdeshev merged commit 48654ed into master May 4, 2016
@hdeshev hdeshev deleted the hdeshev/angular-rc0 branch May 4, 2016 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /