- 
 
- 
  Notifications
 You must be signed in to change notification settings 
- Fork 240
fix(listview) segmentedbar crash #2128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(listview) segmentedbar crash #2128
Conversation
The issue occurs when a list is modified and the segmented bar is reloaded upon scrolling with existing SegmentedBarItems.
If the value is assigned, dereference the current parent assignment.
Not sure who to tag for getting a reviewer for this PR, @vakrilov perhaps?
Sorry to bump, has been a few months now and resolves an open issue.
Is it possible to have someone review this please? @NickIliev
Hi @Codex- thank for this PR - I was able to merge latest master in here (which includes angular 9 support) and would like to get this published by Thursday, thanks for the effort here 👍
Awesome, thanks for that @NathanWalker
Would it be possible to add it as a hotfix release to the existing stable version too? I understand if not!
Definitely - this will go out with 9.0.1 or 9.0.2 this week 🤗
PR Checklist
I ran the appium tests but it couldn't hurt to double check these too. In addition to this, I have also provided a test in the
test-app-ngapplication.Manually tested on both iOS and Android.
What is the current behavior?
In a class with a member that contains an array of
SegmentedBarItems, using this to populate aSegmentedBarin alistView.When the
listViewhas scrolled below the view of theSegmentedBarand the items driving thelistViewchange, scrolling back to theSegmentedBarcauses a hard crash on Android.What is the new behavior?
Introduce a simple check as to whether a new value on
setPropertyInternalis an array, if so, check and unreference any of the items references to aparent&parentNode.The demo page contains a simple list containing a
SegmentedBaras an item, scrolling to the bottom of the list reveals a button that triggers the effect being fixed here. Press this and the list will change, then attempt to scroll to the top of the list.image
image
Fixes #900