Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added setupItemView event for Angular ListView. #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nsndeck merged 1 commit into master from nnikolov/ListViewSetupItemView
Mar 29, 2016

Conversation

@nsndeck
Copy link
Contributor

@nsndeck nsndeck commented Mar 28, 2016

No description provided.

@nsndeck nsndeck force-pushed the nnikolov/ListViewSetupItemView branch from 35c7c66 to 716515a Compare March 29, 2016 08:51
Copy link
Contributor

hdeshev commented Mar 29, 2016

Travis tests fail with an obscure error:
https://travis-ci.org/NativeScript/nativescript-angular/builds/119189389#L1445

👍 after fixing the tests issue


it('setupItemView is called for every item', (done) => {
return testApp.loadComponent(TestListViewComponent).then((componentRef) => {
const componentRoot = componentRef.instance.elementRef.nativeElement;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

componentRoot and listView not needed

Copy link
Contributor

👍

@nsndeck nsndeck force-pushed the nnikolov/ListViewSetupItemView branch 2 times, most recently from d92c71a to 9873053 Compare March 29, 2016 13:57
@nsndeck nsndeck force-pushed the nnikolov/ListViewSetupItemView branch from 9873053 to 9e30852 Compare March 29, 2016 14:08
@nsndeck nsndeck merged commit e8e1f7e into master Mar 29, 2016
@nsndeck nsndeck deleted the nnikolov/ListViewSetupItemView branch March 29, 2016 14:19
Copy link

nx-cloud bot commented Jan 17, 2025
edited
Loading

View your CI Pipeline Execution ↗ for commit 9e30852.

Command Status Duration Result
nx affected --target=build --exclude nativescri... ✅ Succeeded 12s View ↗

☁️ Nx Cloud last updated this comment at 2025年01月17日 15:02:53 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /