-
-
Notifications
You must be signed in to change notification settings - Fork 240
feat: update to Angular 5 animations and add support for AnimationBuilder #1114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ghost
ghost
assigned
sis0k0
Dec 6, 2017
@ghost
ghost
added
the
in progress
label
Dec 6, 2017
@sis0k0
sis0k0
force-pushed
the
vlaeva/animations
branch
from
December 6, 2017 22:24
23fc2fb to
a317325
Compare
The logic for setting/getting template parent is delegated to the ViewBase class.
@sis0k0
sis0k0
force-pushed
the
vlaeva/animations
branch
from
December 6, 2017 22:27
a317325 to
581a78b
Compare
vakrilov
vakrilov
approved these changes
Dec 13, 2017
webpack-testsappng
testsappng
testsappng
sdkwebpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
depends on: NativeScript/NativeScript#5134
Example on using AnimationBuilder (you'll have to use this branch of ns-ng to make it work): https://github.com/NativeScript/ns-ng-animation-examples/blob/master/app/animation-builder.component.ts
related to #1073