-
Couldn't load subscription status.
- Fork 3.4k
Adding UNet3+ support for Tensorflow 2.0 #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi
This is an excellent contribution. It takes a while to review because we have busy time here but I hope to merge this very soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @hamidriasat
- are you OK to change license from MIT to Apache2 which is our default? See here.
- are you OK to move the project under subfolder 'contrib' i.e: TensorFlow2/Segmentation/Contrib/UNet3P?
- other minor comments within a review, please have a look.
DCO Assistant Lite bot All contributors have signed the DCO ✍️ ✅
I have read the DCO Document and I hereby sign the DCO
Yes, I have no issue updating license and directory according to your requirements.
I have completed all three changes
- Updated license to Apache2
- Changed code directory to
Contrib - Incorporated minor reviews in
README
Only the requested changes have been made, rest of the code is similar.
Please have a look at new changes.
UNet3+ in Tensorflow 2.0. For more details about the code and functionality please check
README.mdfile.Things to update while accepting pull request
in the
Installationsection from my forked repo pathI can provide trained model weights in case you want them for testing.
I have tested everything thoroughly but if anything is missing please let me know.
Hope you will like my work.