-
-
Couldn't load subscription status.
- Fork 2
Refactor spinner lesson layout to share scroll scaffold #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@chatgpt-codex-connector
chatgpt-codex-connector
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Inflate merge-root binding without parent
Changing activity_spinner.xml to use a <merge> root removes the zero-argument ActivitySpinnerBinding.inflate(LayoutInflater) overload generated by view binding. The activity still calls ActivitySpinnerBinding.inflate(getLayoutInflater()), which will no longer compile (and even if it did, inflating a <merge> layout without a parent throws IllegalStateException: <merge> can be used only with a valid parent). The inflate call should supply a parent or use setContentView(R.layout.activity_spinner) and ActivitySpinnerBinding.bind(...) instead.
Useful? React with 👍 / 👎.
Summary
lesson_scroll_scaffoldlayout that defines the shared scroll container and show-code FAB<include>SpinnerActivityto inflate the content into the scaffold container and reference the new binding hierarchyTesting
https://chatgpt.com/codex/tasks/task_e_68e6342a3ec4832d94944388c7d27fa5