-
-
Notifications
You must be signed in to change notification settings - Fork 2
Refine top-level navigation motion #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine top-level navigation motion #268
Conversation
@chatgpt-codex-connector
chatgpt-codex-connector
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Guard ValueAnimator.areAnimatorsEnabled for pre-O devices
applyTopLevelNavAnimations now calls ValueAnimator.areAnimatorsEnabled() unconditionally. That API was added in Android O, but the app’s minSdk is 23, so any device running API 23–25 will crash with NoSuchMethodError as soon as this helper executes (e.g., on app start when navigation is set up). Please gate the call behind a Build.VERSION.SDK_INT >= Build.VERSION_CODES.O check or fall back to querying Settings.Global.ANIMATOR_DURATION_SCALE.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Avoid using platform interpolator absent on minSdk
The new fade-through resources reference @android:interpolator/fast_out_extra_slow_in, which was introduced well after API 23. When this animation is inflated on older devices the resource ID is missing and Resources.NotFoundException will be thrown, breaking every top-level navigation transition on those devices. Consider providing a compat interpolator (e.g., via androidx.interpolator or a custom resource packaged in the app) or guard usage by API level.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cefb8d6ce0832d8febf638f866a40a