-
-
Couldn't load subscription status.
- Fork 2
Add AdChoices icon to about banner ad #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AdChoices icon to about banner ad #261
Conversation
@chatgpt-codex-connector
chatgpt-codex-connector
bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Reserve space for the AdChoices icon
The newly added AdChoicesView is anchored to the top-right of the constraint layout, but ad_headline still stretches all the way to parent (app:layout_constraintEnd_toEndOf="parent"). With no constraint or margin between these two views the headline text will occupy the same space as the AdChoices icon, so whichever view is drawn last will obscure the other. AdChoices must remain visible for policy compliance, so the headline should constrain to the start of @id/ad_choices (or similar) to avoid overlap.
Useful? React with 👍 / 👎.
ab0dc7b
into
main
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cdcd01038c832dacc5f2ed5793bce1