Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Convert lessons external link icon to icon button #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaiCristianCondrea merged 2 commits into main from codex/add-icon-button-for-open-in-new
Sep 19, 2025

Conversation

@MihaiCristianCondrea
Copy link
Owner

@MihaiCristianCondrea MihaiCristianCondrea commented Sep 19, 2025

Summary

  • replace the lessons list "open in new" affordance with a Material icon button and provide accessibility text
  • update the lessons adapter to bind the new button and trigger the lesson intent when pressed
  • add a dedicated string resource for the button's description

Testing

  • ./gradlew test (fails: SDK location not found in container)

https://chatgpt.com/codex/tasks/task_e_68cdc42d2bdc832da54885736137f368

chatgpt-codex-connector[bot] reacted with thumbs up emoji
@MihaiCristianCondrea MihaiCristianCondrea merged commit edec758 into main Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /