-
-
Notifications
You must be signed in to change notification settings - Fork 2
Refine edge-to-edge handling across screens #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine edge-to-edge handling across screens #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Apply FAB inset margins regardless of initial visibility
applyInsetsToFloatingButtons bails out when the view is not VISIBLE, so it never attaches the inset listener to FloatingActionButtons that start as INVISIBLE/GONE and are shown later. Those buttons keep their baseline margins and will overlap navigation gesture areas when they become visible, defeating the goal of this delegate. The inset listener should be attached even when the button is hidden so that margins are updated before it is displayed.
Useful? React with 👍 / 👎.
d4fb8c4
into
main
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68cdb3bc4e60832d9d5b0065f1facd28