Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Resolve FIXME warnings across navigation and consent handling #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MihaiCristianCondrea merged 1 commit into main from codex/fix-fixme-comments
Sep 19, 2025

Conversation

@MihaiCristianCondrea
Copy link
Owner

@MihaiCristianCondrea MihaiCristianCondrea commented Sep 19, 2025

Summary

  • replace the Mockito ArgumentCaptor usage in ConsentUtilsTest with explicit consent map verification to eliminate unchecked warnings
  • use pattern matching for instanceof in BaseActivity when enabling optional menu icons
  • guard MainActivity view interactions against null bindings and drop redundant null checks when updating the navigation graph

Testing

  • ./gradlew test (fails: Android SDK is not configured in the environment)

https://chatgpt.com/codex/tasks/task_e_68cd1e29e0a8832da8c917dafe62d0f2

chatgpt-codex-connector[bot] reacted with thumbs up emoji
@MihaiCristianCondrea MihaiCristianCondrea merged commit c9344ad into main Sep 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /