-
-
Notifications
You must be signed in to change notification settings - Fork 2
Add missing translations for preference strings #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing translations for preference strings #159
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Declare tools namespace before using tools:ignore
The new summary_android_history and summary_android_features strings use the tools:ignore attribute, but this resource file (and the other updated locales such as values-hu-rHU, values-in-rID, values-sv-rSE, and values-uk-rUA) does not declare xmlns:tools on the <resources> element. During resource compilation this produces an "unbound prefix: tools" error and prevents the Android app from building. Add xmlns:tools="http://schemas.android.com/tools" to the root element in each affected file before introducing tools: attributes.
Useful? React with 👍 / 👎.
b4a688b
into
main
Summary
Testing
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c5463ddf10832d80fc1b0762082cd8