-
-
Notifications
You must be signed in to change notification settings - Fork 2
Remove quiz feature and resolve FIXMEs #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove quiz feature and resolve FIXMEs #153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P0] Update native ad call sites after signature change
The updated NativeAdBannerView drops the AdRequest parameter and now exposes loadAd()/loadAd(@Nullable AdListener) (lines 47‐52). SupportActivity and HomeFragment still invoke loadAd(request) when initializing their native banners (supportNativeAd.loadAd(adRequest) and smallBannerAd.loadAd(request)), so the project no longer compiles because those method overloads no longer exist. Call sites need to be updated to call the new parameterless API or pass an AdListener instead.
Useful? React with 👍 / 👎.
bf687ad
into
main
Summary
Testing
./gradlew test(fails: SDK location not found)https://chatgpt.com/codex/tasks/task_e_68c4862efb90832d9e4de24438ab0239