Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Apr 13, 2023. It is now read-only.

Github workflows - Markdown lint tool #537

Open
Prome88 wants to merge 1 commit into MathewSachin:master
base: master
Choose a base branch
Loading
from Prome88:master
Open

Github workflows - Markdown lint tool #537

Prome88 wants to merge 1 commit into MathewSachin:master from Prome88:master

Conversation

@Prome88
Copy link
Contributor

@Prome88 Prome88 commented Apr 29, 2020

Github workflows - Markdown lint tool for documentation.

The lint will fail due to few issues in the documentation MD files. Should I also fix those reported issues or wait for v9.0 documentation to do so?

Copy link
Owner

I tried looking around a bit if we can have the lint output viewable without having to see the whole GitHub action logs. It won't be very helpful otherwise. It should use GitHub Actions annotations and show like in this PR: ember-template-lint/ember-template-lint#966

And, do fix the issues for the current files otherwise this will just display all pull-requests as failing to pass tests.

Prome88 reacted with thumbs up emoji

Github workflows - Markdown lint tool for documentation
Copy link
Contributor Author

Prome88 commented Jun 16, 2020

Documentation has been updated to reflect the markdown linter. Implementing viewable output is unfortunately beyond my capabilities.

Should I remove the linter from the commit and just push the updated documentation?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /