Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Ignore API key file from tutorial #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

@blakeNaccarato
Copy link

@blakeNaccarato blakeNaccarato commented Oct 15, 2023
edited
Loading

Just a one-line change to the .gitignore, in case users are following this tutorial in a fork or clone of the repo, say, connected to their account. This should avoid the accidental commit of the user's API key to a public repo.

Notice I made this edit from the GitHub UI, and I think it must've automatically coerced the whitespace at the end of the .gitignore as well, so that's why you see two lines changed.

Copy link
Member

eszmw commented Oct 16, 2023

That's a wonderful idea, Blake! I'll make that update in my next set of changes.

Copy link
Author

Great! Yes, feel free to just copy/paste it in when you need if there's red tape associated with merging this PR directly. I see the Mathworks contributing guide in another of Mathworks' repos requires signing a CLA and all that, which I see is not configured here yet.

I'm really excited about the Python interop, and I'm sure drive-by contributions would be easier if that contribution guide could be ported here.

Copy link
Member

eszmw commented Oct 17, 2023

Right. This seems like an important change, but not worth filling out the requisite copyright paperwork to accept the pull request directly. I will acknowledge your suggestion in the changelog. And if you do get to a point where you want to sign a CLA to contribute something, feel free to let me know. ;)

blakeNaccarato reacted with thumbs up emoji

@eszmw eszmw closed this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /