Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Feature Blizzard API update #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LogansUA wants to merge 8 commits into master
base: master
Choose a base branch
Loading
from feature/new-blizzard-api-update

Conversation

@LogansUA
Copy link
Owner

@LogansUA LogansUA commented Jan 26, 2019

Global library update in order to use Blizzard API after it was updated

Copy link

hey how is progress going on this? I was about to start something similar and would rather help you update this than start over

Copy link
Owner Author

LogansUA commented Feb 11, 2019
edited
Loading

hey how is progress going on this? I was about to start something similar and would rather help you update this than start over

Hey, I'm a bit busy now at work.
If you want to help you can test the WoW part and update SC2/D3 part if you have free time :)

Here's the Postman Collections for Blizzard API you can use them for faster development.

Copy link

Hey @LogansUA, how is progress going on this?

Copy link
Owner Author

LogansUA commented Aug 7, 2019

Hey @LogansUA, how is progress going on this?

Hey, I really forgot about this task.
As I said if you want to help, please help :)

Probably on this weekend I'll take a look and maybe finally finish this one.

albertogcatalan and benargo reacted with thumbs up emoji

Copy link

benargo commented Aug 14, 2019

Hey, I'm using this for WoW, is there anything I can do to help on this front? 🙃

Copy link
Owner Author

Hey, I'm using this for WoW, is there anything I can do to help on this front? 🙃

Well, basically this code should be tested first
Also I'm not sure that I added all changes that are currently have Blizzard API so this thing should be checked too.

benargo reacted with thumbs up emoji

Copy link

benargo commented Aug 15, 2019

Would it be helpful if I created a test suite and added it to this branch/PR?

Copy link
Owner Author

Would it be helpful if I created a test suite and added it to this branch/PR?

I believe it would be great :)

Copy link

benargo commented Aug 16, 2019

Cool, I've forked the branch and started working on this in my spare time. I'll publish what I've got around the end of next week (as I'll be pretty busy once WoW Classic launches 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /