-
-
Notifications
You must be signed in to change notification settings - Fork 41
Allow unnamed modules #185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
codecov-io
commented
Feb 12, 2019
Codecov Report
Merging #185 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #185 +/- ## ======================================= Coverage 70.83% 70.83% ======================================= Files 5 5 Lines 48 48 Branches 11 11 ======================================= Hits 34 34 Misses 11 11 Partials 3 3
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 46c1fb6...4d83977. Read the comment docs.
Thanks for your contribution, would you add some tests before I review your PR?
I will try to give me some time this week-end to check it! 🙂
Currently, marking a component inside of a .vue file with `/** @module */ without providing a full longname results in a parser-inferred longname ending with ".module:vue" which means the inferred shortname is "vue". All its members then also have ".module:vue" in their longname.
I fixed that because I don't want to have to explicitly declare module names, especially in deeply nested files. This also allows the documentation to automatically update when modules are refactored and moved.