-
Couldn't load subscription status.
- Fork 41
CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for Documenter to 1 for package docs, (keep existing compat) #525
Conversation
... existing compat)
fba631a to
e047f40
Compare
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 90.88%. Comparing base (
2a6e5e9) to head (90e85b5).
Additional details and impacted files
@@ Coverage Diff @@ ## master #525 +/- ## =========================================== + Coverage 0.42% 90.88% +90.46% =========================================== Files 52 52 Lines 1423 1459 +36 =========================================== + Hits 6 1326 +1320 + Misses 1417 133 -1284
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
It looks like with the new HTML size threshold the docs cannot be built.
It looks like with the new HTML size threshold the docs cannot be built.
Oooo fun. I wonder if this suggests that we should lower the resolution of some of our figures? My understanding of the size threshold is that it's intended to suggest to you that your page is really quite large, and is probably going to cause issues for users. Do you know if I've got that right?
It looks like with the new HTML size threshold the docs cannot be built.
Oooo fun. I wonder if this suggests that we should lower the resolution of some of our figures? My understanding of the size threshold is that it's intended to suggest to you that your page is really quite large, and is probably going to cause issues for users. Do you know if I've got that right?
Yes that's the idea. Of course there's also the solution to raise the threshold...
Ahhh yeah, that might be better. I mean, no one has complained thus far
Sorry, I deleted the branch by accident.
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
...50-289-02299168519
...50-289-02299168519
This pull request changes the compat entry for the
Documenterpackage from0.27to0.27, 1for package docs.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.