-
Couldn't load subscription status.
- Fork 41
Loosen tolerance on test #495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Patch and project coverage have no change.
Comparison is base (
8746034) 94.25% compared to head (9e30e87) 94.25%.
Additional details and impacted files
@@ Coverage Diff @@ ## master #495 +/- ## ======================================= Coverage 94.25% 94.25% ======================================= Files 52 52 Lines 1374 1374 ======================================= Hits 1295 1295 Misses 79 79
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.
@mjp98 if you could confirm that this seems to fix things on your end, I'll merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the non-standard rtol needed, in particular if we fix the seeds with StableRNGs? Maybe
would be sufficient?
Summary
Replaces an equality test with an approximate equality test to handle roundoff issues. Should resolve #494
Proposed changes
Loosen a test tolerance very slightly
What alternatives have you considered?
None
Breaking changes
None