-
Notifications
You must be signed in to change notification settings - Fork 41
St/dw/scalar parameterhandling/merge #419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
St/dw/scalar parameterhandling/merge #419
Conversation
* restrict Zygote to <0.6.30 * revert Zygote test restriction and add finer-grained testset * Update test/utils.jl Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * revert testset * mark test_broken * Use `@test_throws` instead of `@test_broken` Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
* Fix typo in valid_inputs error * Update src/utils.jl Co-authored-by: David Widmann <devmotion@users.noreply.github.com> Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Zygote AD failures: * revert #409 (test_utils workaround for broken Zygote - now working again) * disable broken Zygote AD test for ChainTransform Improved tests: * finer-grained testsets * add missing test cases to test_AD * replace test_FiniteDiff with test_AD(..., :FiniteDiff, ...) * remove code duplication
* use only() instead of first() for 1-"vectors" that were for the benefit of Flux * fix one test that should not have worked as it was * add missing scalar Sinus constructor
...e test, (keep existing compat) (#418) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org>
...ompat) (#411) Co-authored-by: CompatHelper Julia <compathelper_noreply@julialang.org> Co-authored-by: Théo Galy-Fajou <theo.galyfajou@gmail.com> Co-authored-by: st-- <st--@users.noreply.github.com>
...tions.jl into st/dw/scalar_parameterhandling/merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The branch is outdated, I have additional changes and fixes locally. So unfortunately it's not helpful ro merge this PR currently. I'm sorry but exactly such problems I wanted to avoid, I still think it was a bad idea to make these changes.
Codecov Report
@@ Coverage Diff @@ ## dw/scalar_parameterhandling #419 +/- ## =============================================================== + Coverage 12.62% 12.96% +0.33% =============================================================== Files 53 53 Lines 1386 1396 +10 =============================================================== + Hits 175 181 +6 - Misses 1211 1215 +4
Continue to review full report at Codecov.
|
The branch is outdated, I have additional changes and fixes locally. So unfortunately it's not helpful ro merge this PR currently. I'm sorry but exactly such problems I wanted to avoid, I still think it was a bad idea to make these changes.
Well, it wasn't any work; let me know once you've pushed your local changes, I'm happy to re-do it. I still think it's not a big problem and that it was better to get the other PR in as it is.
Merges master back into #397