Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

👷 Introduce Maven Wrapper #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
McPringle wants to merge 1 commit into JavaMoney:master
base: master
Choose a base branch
Loading
from McPringle:feature/add-maven-wrapper

Conversation

@McPringle
Copy link
Contributor

@McPringle McPringle commented Jan 20, 2023
edited by keilw
Loading

With the Maven Wrapper the contributor does not need to install Maven first. It makes sure that a build is reproducible by using always the same version of Maven for the build.


This change is Reviewable

With the Maven Wrapper the contributor does not need to install Maven first. It makes sure that a build is reproducible by using always the same version of Maven for the build.
@keilw keilw self-requested a review April 25, 2023 18:33
Copy link
Member

@keilw keilw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Travis is malfunctioning (unless you pay for it) we scrapped it, so please redo this PR to fix merge conflicts if you can.

Copy link
Member

stokito commented Apr 25, 2023

IMHO the wrapper is not needed. Developers of the library knows perfectly how to use the Maven. Users may add it into their projects if they wish.
In the same time it adds more files to source tree that also should be updated, cloned, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@keilw keilw keilw requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /