-
Couldn't load subscription status.
- Fork 58
comments added for learning purposes. #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
added closing php tag
Your request changes one of the quotation marks to an apostrophe, but not the ending mark. These should both be changed since interpolation is not occurring within that string. Additionally, a closing PHP tag isn't strictly necessary and there are various positive points supporting leaving the tag out within a PHP-only file.
The first one was made in error. Thanks for catching that.
Re 2nd point, thanks for letting me know its considered poor practice.
Maybe others could make the same mistake if they base it on assumption, I will add a comment with a link to some documentation. Thanks Wolveix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended.
added closing php tag