Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

comments added for learning purposes. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tistudios wants to merge 2 commits into IntuitDeveloper:master
base: master
Choose a base branch
Loading
from tistudios:patch-1

Conversation

@tistudios
Copy link

@tistudios tistudios commented Oct 29, 2018

added closing php tag

Copy link

wolveix commented Jan 22, 2019
edited
Loading

Your request changes one of the quotation marks to an apostrophe, but not the ending mark. These should both be changed since interpolation is not occurring within that string. Additionally, a closing PHP tag isn't strictly necessary and there are various positive points supporting leaving the tag out within a PHP-only file.

Copy link
Author

tistudios commented Jan 28, 2019
edited
Loading

The first one was made in error. Thanks for catching that.

Re 2nd point, thanks for letting me know its considered poor practice.
Maybe others could make the same mistake if they base it on assumption, I will add a comment with a link to some documentation. Thanks Wolveix.

wolveix reacted with thumbs up emoji

Copy link
Author

@tistudios tistudios left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended.

@tistudios tistudios changed the title (削除) Update TimeActivityRead.php (削除ここまで) (追記) comments added for learning purposes. (追記ここまで) Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /