-
Notifications
You must be signed in to change notification settings - Fork 145
Separate out the condition for skipping login #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out the condition for skipping login #376
Conversation
It good look, thank you @jafacakes2011 !
Can I ask you also to increase the version here
https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30
up to 1.5.8?
Then I'll do tests and we'll have a brand new release thank to you :-)
1 similar comment
It good look, thank you @jafacakes2011 !
Can I ask you also to increase the version here
https://github.com/IdentityPython/djangosaml2/blob/master/setup.py#L30
up to 1.5.8?
Then I'll do tests and we'll have a brand new release thank to you :-)
Thanks @peppelinux!
I've bumped the package version as requested 😄
Hi @peppelinux, just nudging on this to see if we can get it merged 😄
The
LoginViewclass has a get method that begins with some logic to determine if the login form should be presented to the current user. If someone wants to override this logic, they have to override the wholegetmethod.This PR separates the conditions into an overridable method so the
getmethod can focus on building the login form/page.