This repository was archived by the owner on Jul 18, 2024. It is now read-only.
-
Couldn't load subscription status.
- Fork 26
Dropping Package Creation and Package Binding #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Getting rid of package kafka and binding kafka-out-binding 2. moving action "mhpost" out of kafka package
1. Removed section 5.1 2. Updated title of sections 5.2 and onwards 3. Added parameters to mhpost action since kafka package no longer exists
krook
krook
approved these changes
May 25, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Dropping package "kafka" and package binding "kafka-out-binding". Moving mhpost-action out of kafka package. Here is the new structure:
As a result of this movement, I had to add command line parameters to mhpost-action which were originally part of "kafka-out-binding".
I have the manifest file created with this new structure but deployment using that manifest doesn't work for two reasons: