Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Jul 18, 2024. It is now read-only.

Dropping Package Creation and Package Binding #36

Merged
krook merged 2 commits into IBM:master from pritidesai:wskdeploy
May 25, 2017

Conversation

@pritidesai
Copy link
Member

@pritidesai pritidesai commented May 19, 2017
edited
Loading

Dropping package "kafka" and package binding "kafka-out-binding". Moving mhpost-action out of kafka package. Here is the new structure:

Action: mhget-action
Action: mhpost-action
Sequence: kafka-sequence
Trigger: kafka-trigger
 Rule: kafka-inbound-rule

As a result of this movement, I had to add command line parameters to mhpost-action which were originally part of "kafka-out-binding".

I have the manifest file created with this new structure but deployment using that manifest doesn't work for two reasons:

  1. Action created with .zip file can be invoked but fails with SyntaxError, issue#273
  2. NPM install is not supported, issue#250
package:
 name: data-processing-message-hub
 namespace: _
 triggers:
 # Creating the kafka-trigger trigger"
 kafka-trigger:
 source: $KAFKA_MESSAGE_HUB_FEED
 inputs:
 isJSONData: true
 topic: $SRC_TOPIC
 actions:
 # Action named "mhget-action"
 # Creating action as a regular Node.js action
 mhget-action:
 location: actions/mhget/mhget.js
 # Action named "mhpost-action"
 # Creating action as a zipped Node.js action, as it contains dependencies
 mhpost-action:
 location: actions/mhpost/mhpost.zip
 runtime: nodejs:6
 inputs:
 api_key: $API_KEY
 kafka_rest_url: $KAFKA_REST_URL
 topic: $DEST_TOPIC
 sequences:
 # Sequence named "kafka-sequence"
 # Creating the sequence that links the get and post actions
 kafka-sequence:
 actions: mhget-action, mhpost-action
 rules:
 # Sequence named "kafka-inbound-rule"
 # Creating the rule that links the trigger to the sequence
 kafka-inbound-rule:
 trigger: kafka-trigger
 action: kafka-sequence

coryma reacted with thumbs up emoji
pritidesai added 2 commits May 18, 2017 12:45
1. Getting rid of package kafka and binding kafka-out-binding
2. moving action "mhpost" out of kafka package
1. Removed section 5.1
2. Updated title of sections 5.2 and onwards
3. Added parameters to mhpost action since kafka package no longer exists
Copy link
Contributor

@krook krook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@krook krook merged commit dccb607 into IBM:master May 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@krook krook krook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /