-
Couldn't load subscription status.
- Fork 56
Element parameter of Steps now can be plain DOM element
#14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
coveralls
commented
Mar 7, 2018
Element parameter now can be plain DOM element (削除ここまで)Element parameter of Steps now can be plain DOM element (追記ここまで)
Hi, thanks for your PR 😄
I didn't take a look or tested the code yet but that seems to be a reasonable change.
I'm a little bit confused however on the updateStepElement changes. The most useful case for this method is when the associated element is not present in the DOM when initialized. If the element is declared using document.querySelectorAll('.example')[0] it'll evaluate immediately to undefined so even when triggering updateStepElement it'll still be undefined.
I may be missing something as I previously said, but if I'm not, maybe it could be worth to consider a refactor of updateStepElement accepting a second argument to redefine the element entirely using either a new string or a DOM element.
Ok, I will take a closer look at about what you did you say.
I am using this in my project, but yes, now I am not sure if it will be working for non-initialized elements.
Closing for inactivity, feel free to re-open if needed.
Uh oh!
There was an error while loading. Please reload this page.
This is extremely useful if we have multiple DOM element with the same class name. E.g: