Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add onBeforeExit callback #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HiDeoo merged 2 commits into HiDeoo:master from Vivalldi:feature/onBeforeExit
Jan 12, 2018
Merged

Add onBeforeExit callback #12

HiDeoo merged 2 commits into HiDeoo:master from Vivalldi:feature/onBeforeExit
Jan 12, 2018

Conversation

@Vivalldi
Copy link
Contributor

@Vivalldi Vivalldi commented Jan 12, 2018

#11 Cleaned-up

Copy link

coveralls commented Jan 12, 2018
edited
Loading

Coverage Status

Coverage decreased (-1.2%) to 98.83% when pulling 7fcf655 on Vivalldi:feature/onBeforeExit into 75e7204 on HiDeoo:master.

Copy link

coveralls commented Jan 12, 2018
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6036508 on Vivalldi:feature/onBeforeExit into 75e7204 on HiDeoo:master.

@HiDeoo HiDeoo merged commit c6d6f90 into HiDeoo:master Jan 12, 2018
Copy link
Owner

HiDeoo commented Jan 12, 2018

Thanks for the PR, I just merged this into master!

I took the liberty to modify some comments and also change the mock you added, I think it was invoked even when not necessary, but besides that, everything was neat 👍

This will be published in the next intro.js-react v0.2.0 release which will be released when intro.js v2.8.0 is out of alpha (altho, if you really need the feature right now, you can still use the master branch in your package.json until then).

I also took your suggestion of adding a proper Prettier configuration as it's now supported.🎉 .

Copy link
Contributor Author

Would you be able to tag the commit with the prerelease? Yarn is not picking it up as of right now

Copy link
Owner

HiDeoo commented Jan 15, 2018

Strange, what did you try?

I just tried (I removed the package before each try to be sure):

yarn add https://github.com/HiDeoo/intro.js-react
yarn add https://github.com/HiDeoo/intro.js-react#master
yarn add https://github.com/HiDeoo/intro.js-react#a475b79

and the 3 commands work and pickup the code with the latest changes from master so if even specifying a specific commit number don't work, I don't think a tag would. Maybe it's an issue in Yarn or a specific version of Yarn (for info I use v1.3.2)?

Copy link
Contributor Author

Ah okay. I was trying to use an alpha release tag even though you haven't done an alpha release tag. I'll just that. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /