Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

使用 retrowrapper 为旧版本做兼容 #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zkitefly wants to merge 11 commits into HMCL-dev:main
base: main
Choose a base branch
Loading
from zkitefly:microsoft-account-skin-uplode

Conversation

@zkitefly
Copy link
Member

@zkitefly zkitefly commented Apr 5, 2025 •
edited
Loading

Close #3512

下载方面,#3247 中已在 DownloadProvider 中添加相关的替换操作,所以下载应该不是什么问题

_org.jackhuang.hmcl.Launcher_20250419214914.mp4

@zkitefly zkitefly requested review from Glavo and Copilot April 5, 2025 10:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

HMCL/src/main/java/org/jackhuang/hmcl/util/NativePatcher.java:79

  • The creation of a LibrariesDownloadInfo object is suspicious since only LibraryDownloadInfo is imported. Please verify if LibrariesDownloadInfo is the correct class to instantiate or if an import for it is missing.
new LibrariesDownloadInfo(

Copy link
Member

是否可以与 BMCLAPI 合作,请求他们托管 retrowrapper 和之前的 unlisted-version-of-minecraft 文件?
zkitefly reacted with eyes emoji

@zkitefly zkitefly marked this pull request as ready for review April 19, 2025 13:32
settings.advanced.dont_patch_natives=不嘗試自動取代本機庫
settings.advanced.dont_use_retrowrapper=不使用 RetroWrapper 修補程式(該修補程式默認僅會在 Minecraft 1.5 及以下版本使用)
Copy link
Contributor

@3gf8jv4dv 3gf8jv4dv Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
settings.advanced.dont_use_retrowrapper=不使用 RetroWrapper 修補程式(該修補程式默認僅會在 Minecraft 1.5 及以下版本使用)
settings.advanced.dont_use_retrowrapper=不使用 RetroWrapper 修補程式(該修補程式預設僅會在 Minecraft 1.5 及此前版本使用)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@Glavo Glavo Awaiting requested review from Glavo

+2 more reviewers

@3gf8jv4dv 3gf8jv4dv 3gf8jv4dv requested changes

@burningtnt burningtnt burningtnt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] 处理不支持微软账号认证的老版本MC,修复账户认证系统和皮肤加载功能

AltStyle によって変換されたページ (->オリジナル) /