Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Fix incorrect implementations of the Hash and PartialEq traits on Table<T> #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TrueDoctor wants to merge 1 commit into master
base: master
Choose a base branch
Loading
from fix-trait-impls-for-table

Conversation

@TrueDoctor
Copy link
Member

@TrueDoctor TrueDoctor commented Oct 23, 2025 •
edited
Loading

Previously we did not include information like the transforms for determining equality of table instances. This caused caching of values should have been different

Copy link

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 27,643,156 (master) → 27,642,353 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 4 -0.08%
D1mr 350,028| 349,726 -0.09%
D1mw 108,324| 108,269 -0.05%
DLmr 31,089| 31,076 -0.04%
DLmw 49,706| 49,690 -0.03%
Dr 6,820,989| 6,820,894 -0.00%
Dw 4,765,158| 4,765,157 -0.00%
EstimatedCycles 43,723,289| 43,751,530 +0.06%
I1MissRate 0| 0 +14.94%
I1mr 52,777| 60,659 +14.93%
ILmr 854| 851 -0.35%
Ir 27,643,156| 27,642,353 -0.00%
L1HitRate 99| 99 -0.02%
L1hits 38,718,174| 38,709,750 -0.02%
LLHitRate 1| 1 +1.76%
LLMissRate 0| 0 -0.04%
LLdMissRate 1| 1 -0.04%
LLhits 429,480| 437,037 +1.76%
LLiMissRate 0| 0 -0.35%
RamHitRate 0| 0 -0.04%
RamHits 81,649| 81,617 -0.04%
TotalRW 39,229,303| 39,228,404 -0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 13,872,486 (master) → 13,871,860 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 4 +0.17%
D1mr 168,300| 168,453 +0.09%
D1mw 53,287| 53,513 +0.42%
DLmr 772| 756 -2.07%
DLmw 16,032| 16,031 -0.01%
Dr 3,433,054| 3,432,936 -0.00%
Dw 2,389,095| 2,389,100 +0.00%
EstimatedCycles 21,209,803| 21,224,904 +0.07%
I1MissRate 0| 0 +14.24%
I1mr 25,895| 29,581 +14.23%
ILmr 704| 707 +0.43%
Ir 13,872,486| 13,871,860 -0.00%
L1HitRate 99| 99 -0.02%
L1hits 19,447,153| 19,442,349 -0.02%
LLHitRate 1| 1 +1.78%
LLMissRate 0| 0 -0.08%
LLdMissRate 0| 0 -0.10%
LLhits 229,974| 234,053 +1.77%
LLiMissRate 0| 0 +0.43%
RamHitRate 0| 0 -0.08%
RamHits 17,508| 17,494 -0.08%
TotalRW 19,694,635| 19,693,896 -0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 3,085,964 (master) → 3,084,976 (HEAD) : $$\color{lime}-0.03\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 4 -0.02%
D1mr 36,551| 36,511 -0.11%
D1mw 10,630| 10,656 +0.24%
DLmr 13| 12 -7.69%
DLmw 2,944| 2,941 -0.10%
Dr 751,634| 751,487 -0.02%
Dw 524,581| 524,559 -0.00%
EstimatedCycles 4,681,821| 4,683,416 +0.03%
I1MissRate 0| 0 +13.06%
I1mr 5,392| 6,094 +13.02%
ILmr 688| 692 +0.58%
Ir 3,085,964| 3,084,976 -0.03%
L1HitRate 99| 99 -0.02%
L1hits 4,309,606| 4,307,761 -0.04%
LLHitRate 1| 1 +1.43%
LLMissRate 0| 0 +0.03%
LLdMissRate 0| 0 -0.12%
LLhits 48,928| 49,616 +1.41%
LLiMissRate 0| 0 +0.61%
RamHitRate 0| 0 +0.03%
RamHits 3,645| 3,645 +0.00%
TotalRW 4,362,179| 4,361,022 -0.03%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 13,671,855 (master) → 13,671,427 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 4 +0.04%
D1mr 171,441| 171,441 +0.00%
D1mw 49,531| 49,611 +0.16%
DLmr 49| 50 +2.04%
DLmw 11,165| 11,150 -0.13%
Dr 3,338,086| 3,337,922 -0.00%
Dw 2,347,032| 2,346,913 -0.01%
EstimatedCycles 20,683,451| 20,691,650 +0.04%
I1MissRate 0| 0 +11.15%
I1mr 20,415| 22,690 +11.14%
ILmr 817| 814 -0.37%
Ir 13,671,855| 13,671,427 -0.00%
L1HitRate 99| 99 -0.01%
L1hits 19,115,586| 19,112,520 -0.02%
LLHitRate 1| 1 +1.04%
LLMissRate 0| 0 -0.14%
LLdMissRate 0| 0 -0.12%
LLhits 229,356| 231,728 +1.03%
LLiMissRate 0| 0 -0.36%
RamHitRate 0| 0 -0.14%
RamHits 12,031| 12,014 -0.14%
TotalRW 19,356,973| 19,356,262 -0.00%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 32,120,374 (master) → 32,123,346 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 4 -0.09%
D1mr 407,587| 407,165 -0.10%
D1mw 124,569| 124,516 -0.04%
DLmr 42,452| 42,451 -0.00%
DLmw 49,117| 49,104 -0.03%
Dr 7,900,628| 7,901,002 +0.00%
Dw 5,526,341| 5,526,365 +0.00%
EstimatedCycles 50,681,759| 50,717,641 +0.07%
I1MissRate 0| 0 +15.00%
I1mr 58,223| 66,961 +15.01%
ILmr 861| 857 -0.46%
Ir 32,120,374| 32,123,346 +0.01%
L1HitRate 99| 99 -0.02%
L1hits 44,956,964| 44,952,071 -0.01%
LLHitRate 1| 1 +1.66%
LLMissRate 0| 0 -0.03%
LLdMissRate 1| 1 -0.02%
LLhits 497,949| 506,230 +1.66%
LLiMissRate 0| 0 -0.47%
RamHitRate 0| 0 -0.03%
RamHits 92,430| 92,412 -0.02%
TotalRW 45,547,343| 45,550,713 +0.01%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 21,187,638 (master) → 21,187,986 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 4 +0.08%
D1mr 263,095| 263,225 +0.05%
D1mw 77,400| 77,532 +0.17%
DLmr 15,005| 14,982 -0.15%
DLmw 35,438| 35,466 +0.08%
Dr 5,232,319| 5,232,395 +0.00%
Dw 3,652,130| 3,652,171 +0.00%
EstimatedCycles 33,128,537| 33,154,276 +0.08%
I1MissRate 0| 0 +15.51%
I1mr 39,190| 45,269 +15.51%
ILmr 814| 806 -0.98%
Ir 21,187,638| 21,187,986 +0.00%
L1HitRate 99| 99 -0.02%
L1hits 29,692,402| 29,686,526 -0.02%
LLHitRate 1| 1 +1.93%
LLMissRate 0| 0 -0.01%
LLdMissRate 1| 1 +0.01%
LLhits 328,428| 334,772 +1.93%
LLiMissRate 0| 0 -0.98%
RamHitRate 0| 0 -0.01%
RamHits 51,257| 51,254 -0.01%
TotalRW 30,072,087| 30,072,552 +0.00%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 46,812,534 (master) → 46,723,269 (HEAD) : $$\color{lime}-0.19\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 -0.29%
D1mr 498,338| 493,852 -0.90%
D1mw 111,605| 113,111 +1.35%
DLmr 3,509| 3,446 -1.80%
DLmw 20,368| 18,745 -7.97%
Dr 11,748,372| 11,728,342 -0.17%
Dw 8,028,354| 8,009,336 -0.24%
EstimatedCycles 69,795,912| 69,775,111 -0.03%
I1MissRate 0| 0 +383.82%
I1mr 11,120| 53,698 +382.90%
ILmr 203| 193 -4.93%
Ir 46,812,534| 46,723,269 -0.19%
L1HitRate 99| 99 -0.06%
L1hits 65,968,197| 65,800,286 -0.25%
LLHitRate 1| 1 +7.12%
LLMissRate 0| 0 -6.86%
LLdMissRate 0| 0 -6.88%
LLhits 596,983| 638,277 +6.92%
LLiMissRate 0| 0 -4.74%
RamHitRate 0| 0 -6.86%
RamHits 24,080| 22,384 -7.04%
TotalRW 66,589,260| 66,460,947 -0.19%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 24,210,868 (master) → 24,210,327 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 -0.12%
D1mr 250,027| 250,017 -0.00%
D1mw 56,097| 55,609 -0.87%
DLmr 982| 983 +0.10%
DLmw 3,585| 3,973 +10.82%
Dr 6,081,557| 6,081,180 -0.01%
Dw 4,147,087| 4,142,758 -0.10%
EstimatedCycles 35,828,844| 35,934,967 +0.30%
I1MissRate 0| 0 +453.13%
I1mr 5,614| 31,052 +453.12%
ILmr 179| 177 -1.12%
Ir 24,210,868| 24,210,327 -0.00%
L1HitRate 99| 99 -0.07%
L1hits 34,127,774| 34,097,587 -0.09%
LLHitRate 1| 1 +8.01%
LLMissRate 0| 0 +8.17%
LLdMissRate 0| 0 +8.57%
LLhits 306,992| 331,545 +8.00%
LLiMissRate 0| 0 -1.12%
RamHitRate 0| 0 +8.17%
RamHits 4,746| 5,133 +8.15%
TotalRW 34,439,512| 34,434,265 -0.02%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 6,046,701 (master) → 6,257,967 (HEAD) : $$\color{red}+3.49\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 +5.01%
D1mr 58,951| 65,137 +10.49%
D1mw 14,715| 15,021 +2.08%
DLmr NaN| NaN +0.00%
DLmw 539| 549 +1.86%
Dr 1,539,535| 1,596,813 +3.72%
Dw 1,059,007| 1,095,844 +3.48%
EstimatedCycles 8,973,009| 9,327,268 +3.95%
I1MissRate 0| 0 +184.37%
I1mr 2,913| 8,573 +194.30%
ILmr 176| 175 -0.57%
Ir 6,046,701| 6,257,967 +3.49%
L1HitRate 99| 99 -0.11%
L1hits 8,568,664| 8,861,893 +3.42%
LLHitRate 1| 1 +12.05%
LLMissRate 0| 0 -2.20%
LLdMissRate 0| 0 -1.70%
LLhits 75,864| 88,007 +16.01%
LLiMissRate 0| 0 -3.92%
RamHitRate 0| 0 -2.20%
RamHits 715| 724 +1.26%
TotalRW 8,645,243| 8,950,624 +3.53%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 28,173,680 (master) → 28,063,046 (HEAD) : $$\color{lime}-0.39\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 +1.15%
D1mr 276,772| 275,213 -0.56%
D1mw 70,237| 68,508 -2.46%
DLmr 191| 200 +4.71%
DLmw 4,221| 4,049 -4.07%
Dr 7,167,065| 7,040,930 -1.76%
Dw 4,996,609| 4,870,883 -2.52%
EstimatedCycles 41,884,256| 41,578,431 -0.73%
I1MissRate 0| 0 +350.02%
I1mr 5,359| 24,022 +348.26%
ILmr 169| 171 +1.18%
Ir 28,173,680| 28,063,046 -0.39%
L1HitRate 99| 99 -0.05%
L1hits 39,984,986| 39,607,116 -0.95%
LLHitRate 1| 1 +5.41%
LLMissRate 0| 0 -2.64%
LLdMissRate 0| 0 -1.66%
LLhits 347,787| 363,323 +4.47%
LLiMissRate 0| 0 +1.58%
RamHitRate 0| 0 -2.64%
RamHits 4,581| 4,420 -3.51%
TotalRW 40,337,354| 39,974,859 -0.90%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 63,894,557 (master) → 64,036,914 (HEAD) : $$\color{red}+0.22\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 +0.63%
D1mr 657,298| 665,531 +1.25%
D1mw 152,849| 157,590 +3.10%
DLmr 16,997| 16,496 -2.95%
DLmw 35,698| 33,168 -7.09%
Dr 16,208,795| 16,341,084 +0.82%
Dw 11,104,951| 11,235,990 +1.18%
EstimatedCycles 96,081,009| 96,662,918 +0.61%
I1MissRate 0| 0 +549.79%
I1mr 9,772| 63,639 +551.24%
ILmr 406| 399 -1.72%
Ir 63,894,557| 64,036,914 +0.22%
L1HitRate 99| 99 -0.07%
L1hits 90,388,384| 90,727,228 +0.37%
LLHitRate 1| 1 +8.63%
LLMissRate 0| 0 -6.14%
LLdMissRate 0| 0 -6.65%
LLhits 766,818| 836,697 +9.11%
LLiMissRate 0| 0 -1.94%
RamHitRate 0| 0 -6.14%
RamHits 53,101| 50,063 -5.72%
TotalRW 91,208,303| 91,613,988 +0.44%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 36,011,900 (master) → 35,967,842 (HEAD) : $$\color{lime}-0.12\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 +0.09%
D1mr 383,923| 383,508 -0.11%
D1mw 84,776| 85,076 +0.35%
DLmr 2,620| 2,640 +0.76%
DLmw 8,453| 8,852 +4.72%
Dr 9,017,389| 9,008,708 -0.10%
Dw 6,126,894| 6,117,725 -0.15%
EstimatedCycles 53,401,231| 53,493,433 +0.17%
I1MissRate 0| 0 +436.80%
I1mr 8,143| 43,658 +436.14%
ILmr 183| 181 -1.09%
Ir 36,011,900| 35,967,842 -0.12%
L1HitRate 99| 99 -0.07%
L1hits 50,679,341| 50,582,033 -0.19%
LLHitRate 1| 1 +7.64%
LLMissRate 0| 0 +3.83%
LLdMissRate 0| 0 +3.91%
LLhits 465,586| 500,569 +7.51%
LLiMissRate 0| 0 -0.97%
RamHitRate 0| 0 +3.83%
RamHits 11,256| 11,673 +3.70%
TotalRW 51,156,183| 51,094,275 -0.12%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 22,688,714 (master) → 22,632,214 (HEAD) : $$\color{lime}-0.25\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 +0.23%
D1mr 277,230| 275,557 -0.60%
D1mw 62,863| 61,834 -1.64%
DLmr 8,061| 7,899 -2.01%
DLmw 9,533| 8,989 -5.71%
Dr 5,969,068| 5,917,786 -0.86%
Dw 4,072,064| 4,021,044 -1.25%
EstimatedCycles 35,316,686| 35,121,108 -0.55%
I1MissRate 1| 1 -0.78%
I1mr 134,237| 132,860 -1.03%
ILmr 5,390| 5,414 +0.45%
Ir 22,688,714| 22,632,214 -0.25%
L1HitRate 99| 99 +0.01%
L1hits 32,255,516| 32,100,793 -0.48%
LLHitRate 1| 1 -0.27%
LLMissRate 0| 0 -2.49%
LLdMissRate 0| 0 -3.02%
LLhits 451,346| 447,949 -0.75%
LLiMissRate 0| 0 +0.70%
RamHitRate 0| 0 -2.49%
RamHits 22,984| 22,302 -2.97%
TotalRW 32,729,846| 32,571,044 -0.49%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 80,104,192 (master) → 80,111,270 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 2| 2 +0.03%
D1mr 411,124| 411,786 +0.16%
D1mw 195,254| 195,104 -0.08%
DLmr 3,850| 3,836 -0.36%
DLmw 20,360| 20,227 -0.65%
Dr 18,894,325| 18,903,306 +0.05%
Dw 12,595,676| 12,604,951 +0.07%
EstimatedCycles 115,716,005|115,723,593 +0.01%
I1MissRate 0| 0 -2.11%
I1mr 185,620| 181,714 -2.10%
ILmr 7,584| 7,592 +0.11%
Ir 80,104,192| 80,111,270 +0.01%
L1HitRate 99| 99 +0.00%
L1hits 110,802,195|110,830,923 +0.03%
LLHitRate 1| 1 -0.45%
LLMissRate 0| 0 -0.46%
LLdMissRate 0| 0 -0.66%
LLhits 760,204| 756,949 -0.43%
LLiMissRate 0| 0 +0.10%
RamHitRate 0| 0 -0.46%
RamHits 31,794| 31,655 -0.44%
TotalRW 111,594,193|111,619,527 +0.02%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 10,539,491 (master) → 10,572,905 (HEAD) : $$\color{red}+0.32\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 2| 2 +1.09%
D1mr 59,634| 60,903 +2.13%
D1mw 23,614| 24,357 +3.15%
DLmr 401| 393 -2.00%
DLmw 1,176| 1,221 +3.83%
Dr 2,604,923| 2,634,944 +1.15%
Dw 1,882,434| 1,911,526 +1.55%
EstimatedCycles 15,739,528| 15,831,605 +0.59%
I1MissRate 0| 0 -5.21%
I1mr 49,487| 47,055 -4.91%
ILmr 4,481| 4,485 +0.09%
Ir 10,539,491| 10,572,905 +0.32%
L1HitRate 99| 99 +0.01%
L1hits 14,894,113| 14,987,060 +0.62%
LLHitRate 1| 1 -0.97%
LLMissRate 0| 0 +0.06%
LLdMissRate 0| 0 +1.02%
LLhits 126,677| 126,216 -0.36%
LLiMissRate 0| 0 -0.23%
RamHitRate 0| 0 +0.06%
RamHits 6,058| 6,099 +0.68%
TotalRW 15,026,848| 15,119,375 +0.62%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 23,716,183 (master) → 23,678,576 (HEAD) : $$\color{lime}-0.16\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 2| 2 +0.09%
D1mr 161,722| 160,706 -0.63%
D1mw 64,034| 64,578 +0.85%
DLmr 2,255| 2,267 +0.53%
DLmw 6,214| 6,432 +3.51%
Dr 5,722,813| 5,708,117 -0.26%
Dw 3,830,682| 3,816,928 -0.36%
EstimatedCycles 34,829,252| 34,757,031 -0.21%
I1MissRate 0| 0 -3.58%
I1mr 72,345| 69,641 -3.74%
ILmr 3,770| 3,758 -0.32%
Ir 23,716,183| 23,678,576 -0.16%
L1HitRate 99| 99 +0.01%
L1hits 32,971,577| 32,908,696 -0.19%
LLHitRate 1| 1 -0.99%
LLMissRate 0| 0 +1.98%
LLdMissRate 0| 0 +3.02%
LLhits 285,862| 282,468 -1.19%
LLiMissRate 0| 0 -0.16%
RamHitRate 0| 0 +1.98%
RamHits 12,239| 12,457 +1.78%
TotalRW 33,269,678| 33,203,621 -0.20%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,806,465,182 (master) → 1,806,386,014 (HEAD) : $$\color{lime}-0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 0| 0 +1.28%
D1mr 1,858,114| 1,879,749 +1.16%
D1mw 869,754| 882,212 +1.43%
DLmr 455,102| 452,161 -0.65%
DLmw 522,594| 522,769 +0.03%
Dr 432,219,634|432,126,542 -0.02%
Dw 278,715,127|278,618,692 -0.03%
EstimatedCycles 2,562,925,737|2,562,281,252 -0.03%
I1MissRate 0| 0 -8.37%
I1mr 1,280,443| 1,173,155 -8.38%
ILmr 5,389| 5,388 -0.02%
Ir 1,806,465,182|1,806,386,014 -0.00%
L1HitRate 100| 100 +0.00%
L1hits 2,513,391,632|2,513,196,132 -0.01%
LLHitRate 0| 0 -2.32%
LLMissRate 0| 0 -0.27%
LLdMissRate 0| 0 -0.26%
LLhits 3,025,226| 2,954,798 -2.33%
LLiMissRate 0| 0 -0.01%
RamHitRate 0| 0 -0.27%
RamHits 983,085| 980,318 -0.28%
TotalRW 2,517,399,943|2,517,131,248 -0.01%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 20,575,437 (master) → 20,555,008 (HEAD) : $$\color{lime}-0.10\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 3| 3 +0.85%
D1mr 220,589| 220,903 +0.14%
D1mw 53,899| 53,663 -0.44%
DLmr 5,647| 5,649 +0.04%
DLmw 6,729| 7,065 +4.99%
Dr 5,166,007| 5,131,804 -0.66%
Dw 3,480,782| 3,444,823 -1.03%
EstimatedCycles 31,235,550| 31,145,207 -0.29%
I1MissRate 1| 1 -2.14%
I1mr 109,158| 106,712 -2.24%
ILmr 3,582| 3,568 -0.39%
Ir 20,575,437| 20,555,008 -0.10%
L1HitRate 99| 99 +0.00%
L1hits 28,838,580| 28,750,357 -0.31%
LLHitRate 1| 1 -0.42%
LLMissRate 0| 0 +2.35%
LLdMissRate 0| 0 +3.57%
LLhits 367,688| 364,996 -0.73%
LLiMissRate 0| 0 -0.29%
RamHitRate 0| 0 +2.35%
RamHits 15,958| 16,282 +2.03%
TotalRW 29,222,226| 29,131,635 -0.31%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 7,926,320 (master) → 7,927,401 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 5| 5 +0.67%
D1mr 194,252| 195,482 +0.63%
D1mw 7,598| 7,756 +2.08%
DLmr 1,005| 910 -9.45%
DLmw 148| 96 -35.14%
Dr 2,413,266| 2,413,633 +0.02%
Dw 1,433,536| 1,433,774 +0.02%
EstimatedCycles 12,622,986| 12,625,776 +0.02%
I1MissRate 0| 0 +1.84%
I1mr 701| 714 +1.85%
ILmr 169| 166 -1.78%
Ir 7,926,320| 7,927,401 +0.01%
L1HitRate 98| 98 -0.01%
L1hits 11,570,571| 11,570,856 +0.00%
LLHitRate 2| 2 +0.76%
LLMissRate 0| 0 -11.36%
LLdMissRate 0| 0 -12.76%
LLhits 201,229| 202,780 +0.77%
LLiMissRate 0| 0 -1.79%
RamHitRate 0| 0 -11.36%
RamHits 1,322| 1,172 -11.35%
TotalRW 11,773,122| 11,774,808 +0.01%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 5,951,197 (master) → 5,951,874 (HEAD) : $$\color{red}+0.01\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 5| 5 +0.74%
D1mr 129,349| 130,458 +0.86%
D1mw 7,233| 7,172 -0.84%
DLmr 187| 151 -19.25%
DLmw 16| 11 -31.25%
Dr 1,851,837| 1,852,219 +0.02%
Dw 1,108,925| 1,109,368 +0.04%
EstimatedCycles 9,471,817| 9,476,421 +0.05%
I1MissRate 0| 0 +2.83%
I1mr 705| 725 +2.84%
ILmr 154| 156 +1.30%
Ir 5,951,197| 5,951,874 +0.01%
L1HitRate 98| 98 -0.01%
L1hits 8,774,672| 8,775,106 +0.00%
LLHitRate 2| 2 +0.79%
LLMissRate 0| 0 -10.94%
LLdMissRate 0| 0 -20.22%
LLhits 136,930| 138,037 +0.81%
LLiMissRate 0| 0 +1.29%
RamHitRate 0| 0 -10.94%
RamHits 357| 318 -10.92%
TotalRW 8,911,959| 8,913,461 +0.02%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(procedural-string-lights)
Instructions: 1,712,108 (master) → 1,487,157 (HEAD) : $$\color{lime}-13.14\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 4| 3 -9.16%
D1mr 32,840| 26,110 -20.49%
D1mw 3,786| 3,670 -3.06%
DLmr 6| 7 +16.67%
DLmw NaN| NaN +0.00%
Dr 582,557| 520,817 -10.60%
Dw 380,150| 340,857 -10.34%
EstimatedCycles 2,828,637| 2,475,331 -12.49%
I1MissRate 0| 0 +16.42%
I1mr 712| 720 +1.12%
ILmr 143| 143 +0.00%
Ir 1,712,108| 1,487,157 -13.14%
L1HitRate 99| 99 +0.10%
L1hits 2,637,477| 2,318,331 -12.10%
LLHitRate 1| 1 -7.06%
LLMissRate 0| 0 +14.64%
LLdMissRate 0| 0 +30.35%
LLhits 37,189| 30,350 -18.39%
LLiMissRate 0| 0 +15.13%
RamHitRate 0| 0 +14.64%
RamHits 149| 150 +0.67%
TotalRW 2,674,815| 2,348,831 -12.19%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(parametric-dunescape)
Instructions: 3,752,174 (master) → 3,753,187 (HEAD) : $$\color{red}+0.03\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 5| 5 -0.28%
D1mr 94,001| 93,702 -0.32%
D1mw 7,718| 7,751 +0.43%
DLmr 40| 38 -5.00%
DLmw 42| 17 -59.52%
Dr 1,277,168| 1,277,476 +0.02%
Dw 839,331| 839,376 +0.01%
EstimatedCycles 6,284,751| 6,284,231 -0.01%
I1MissRate 0| 0 +3.98%
I1mr 673| 700 +4.01%
ILmr 135| 131 -2.96%
Ir 3,752,174| 3,753,187 +0.03%
L1HitRate 98| 98 +0.00%
L1hits 5,766,281| 5,767,886 +0.03%
LLHitRate 2| 2 -0.23%
LLMissRate 0| 0 -14.31%
LLdMissRate 0| 0 -32.94%
LLhits 102,175| 101,967 -0.20%
LLiMissRate 0| 0 -2.99%
RamHitRate 0| 0 -14.31%
RamHits 217| 186 -14.29%
TotalRW 5,868,673| 5,870,039 +0.02%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(red-dress)
Instructions: 35,580,455 (master) → 35,580,634 (HEAD) : $$\color{red}+0.00\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 5| 5 -0.09%
D1mr 685,491| 684,641 -0.12%
D1mw 101,023| 101,179 +0.15%
DLmr 302,096| 302,878 +0.26%
DLmw 55,070| 53,814 -2.28%
Dr 10,145,980| 10,146,181 +0.00%
Dw 5,496,072| 5,495,837 -0.00%
EstimatedCycles 65,108,863| 65,092,114 -0.03%
I1MissRate 0| 0 +0.39%
I1mr 765| 768 +0.39%
ILmr 742| 745 +0.40%
Ir 35,580,455| 35,580,634 +0.00%
L1HitRate 98| 98 +0.00%
L1hits 50,435,228| 50,436,064 +0.00%
LLHitRate 1| 1 -0.05%
LLMissRate 1| 1 -0.13%
LLdMissRate 2| 2 -0.13%
LLhits 429,371| 429,151 -0.05%
LLiMissRate 0| 0 +0.40%
RamHitRate 1| 1 -0.13%
RamHits 357,908| 357,437 -0.13%
TotalRW 51,222,507| 51,222,652 +0.00%

run_cached_iai::run_cached_group::run_cached with_setup_5:setup_run_cached(valley-of-spires)
Instructions: 6,304,394 (master) → 6,312,339 (HEAD) : $$\color{red}+0.13\%$$

Detailed metrics 
Baselines: master| HEAD
D1MissRate 5| 5 -0.30%
D1mr 153,469| 153,985 +0.34%
D1mw 6,508| 6,490 -0.28%
DLmr 211| 203 -3.79%
DLmw 170| 151 -11.18%
Dr 1,883,243| 1,892,344 +0.48%
Dw 1,100,001| 1,109,122 +0.83%
EstimatedCycles 9,946,466| 9,973,909 +0.28%
I1MissRate 0| 0 +2.17%
I1mr 695| 711 +2.30%
ILmr 157| 158 +0.64%
Ir 6,304,394| 6,312,339 +0.13%
L1HitRate 98| 98 -0.00%
L1hits 9,126,966| 9,152,619 +0.28%
LLHitRate 2| 2 +0.06%
LLMissRate 0| 0 -5.10%
LLdMissRate 0| 0 -7.65%
LLhits 160,134| 160,674 +0.34%
LLiMissRate 0| 0 +0.51%
RamHitRate 0| 0 -5.10%
RamHits 538| 512 -4.83%
TotalRW 9,287,638| 9,313,805 +0.28%

@Keavon Keavon changed the title (削除) Fix incorrect implementations of the Hash and PartialEq traits on Table (削除ここまで) (追記) Fix incorrect implementations of the Hash and PartialEq traits on Table<T> (追記ここまで) Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keavon Keavon Awaiting requested review from Keavon

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /