Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add TypeScript declarations to the published package #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lorensr merged 2 commits into master from adi-fix-typescript-packing
Mar 27, 2020

Conversation

@9at8
Copy link
Collaborator

@9at8 9at8 commented Mar 27, 2020 •
edited
Loading

Closes #19

What changed?

  • Adds index.d.ts to files as mentioned here
  • Moves @types/mongodb and @types/mongoose to dependencies as mentioned here

How did I test it?

  • Created a local package using npm pack and installed that in a project.
    • Ran tsc in that project, and there weren't any type errors.

cc @jblevins1991

@9at8 9at8 requested a review from lorensr March 27, 2020 06:02
@lorensr lorensr merged commit 7d33b0b into master Mar 27, 2020
@9at8 9at8 deleted the adi-fix-typescript-packing branch March 27, 2020 06:15
Copy link
Member

lorensr commented Mar 27, 2020

Published in 0.2.5
9at8 reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lorensr lorensr Awaiting requested review from lorensr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

MongoDataSource Typescript issues

3 participants

AltStyle によって変換されたページ (->オリジナル) /