-
Couldn't load subscription status.
- Fork 64
correct typings for mongoose model #110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey @sojharo, sorry for the delay, and thanks for the contribution! Did you test the types manually for both MongoDB Collections and Mongoose Models? If you feel like an automated test (just running tsc on an example ts file), that would be helpful
Hey, I had the library installed in my current project and went into node_modules folder to do the changes and then test with my current project. I was able to reproduce the issue and then solve it with these changes in index.d.ts which are in this PR. When I run the project, I compile it using sucrase-node library so it compiles the typescript to javascript.
andrmaz
commented
Jan 3, 2023
@lorensr Any progress on this PR ?
Hey, yes. I had tested them with tsc and also tested it with my project by doing these changes directly inside installed version inside node_modules folder.
Types should not extend Document as per discussion in #88