Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(genai): live samples part1 #4190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gericdong merged 22 commits into GoogleCloudPlatform:main from Guiners:sample/live-part1
Nov 3, 2025

Conversation

@Guiners
Copy link
Contributor

@Guiners Guiners commented Oct 14, 2025 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners October 14, 2025 13:37
Copy link

snippet-bot bot commented Oct 14, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 14, 2025
Copy link
Contributor

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers the first part of live samples for the Google GenAI SDK, providing developers with practical, real-time examples. These samples are designed to illustrate how to leverage the gemini-2.0-flash-live-preview-04-09 model for interactive applications, covering a spectrum of use cases from simple text chat to complex tool integrations like code execution and external search, thereby enhancing the SDK's documentation and usability.

Highlights

  • New Live Samples for Google GenAI SDK: This pull request introduces a collection of new 'live' samples for the Google GenAI SDK, demonstrating real-time interaction capabilities with the Gemini 2.0 Flash Live Preview model.
  • Diverse Interaction Modalities: The new samples cover various interaction modalities, including basic text conversations, audio-based conversations, and advanced functionalities like code execution, function calling, and Google Search grounding.
  • Comprehensive Test Coverage: Each new live sample is accompanied by a dedicated test file, ensuring the functionality and reliability of the demonstrated features.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a set of live samples for the GenAI SDK, demonstrating features like code execution, audio conversations, function calling, and grounding with Google Search. The code is well-structured and provides good examples of how to use the live API.

My review includes a few suggestions for improvement:

  • A recurring pattern of using polling with setTimeout to wait for messages is present in all samples. I've suggested a more efficient, event-driven approach.
  • There is a potential bug in the audio conversation sample that could lead to a crash if a message times out. I've provided a fix for this.
  • The audio sample also makes an assumption about the WAV file header size which could be brittle.
  • There's a minor typo in a test filename (genai/test/live-conversation-audio-with-audio.js.test.js) which should be corrected for consistency to genai/test/live-conversation-audio-with-audio.test.js.

Overall, these are great additions. My feedback aims to make them more robust and efficient.

Copy link

cfloress commented Oct 14, 2025 •
edited
Loading

Besides @jdomingr comment...... LGTM

@gericdong gericdong merged commit f19d350 into GoogleCloudPlatform:main Nov 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gericdong gericdong gericdong approved these changes

+2 more reviewers

@jdomingr jdomingr jdomingr left review comments

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /