Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(genai): bump sdk version #4185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msampathkumar merged 10 commits into GoogleCloudPlatform:main from Guiners:sample/version-update
Oct 3, 2025

Conversation

@Guiners
Copy link
Contributor

@Guiners Guiners commented Sep 29, 2025 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@Guiners Guiners requested review from a team as code owners September 29, 2025 11:11
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 29, 2025
Copy link
Contributor

Summary of Changes

Hello @Guiners, I'm Gemini Code Assist1 ! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on updating the SDK usage within the Generative AI samples. The primary change involves standardizing the client variable name for the GoogleGenAI instance and updating a specific model name for image generation, ensuring the samples align with the latest SDK conventions and available models.

Highlights

  • SDK Client Variable Renaming: The ai variable, used for the GoogleGenAI client instance, has been consistently renamed to client across all affected files for improved clarity and consistency.
  • Image Generation Model Update: The model used for image generation in imggen-mmflash-with-txt.js has been updated from gemini-2.0-flash-exp to gemini-2.5-flash-image-preview, reflecting an SDK version update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily refactors the GenAI samples by renaming the GoogleGenAI instance variable from ai to client for improved clarity. It also updates a model name in one of the image generation samples. The changes are good for maintainability. I've added one suggestion to extract the hardcoded model name into a constant to further improve the code.

@Guiners Guiners changed the title (削除) feat(genai): SDK version update (削除ここまで) (追記) feat(genai):SDK-version-update (追記ここまで) Sep 29, 2025
@Guiners Guiners changed the title (削除) feat(genai):SDK-version-update (削除ここまで) (追記) feat(genai): bump sdk version (追記ここまで) Sep 29, 2025
Copy link

LGTM :)

@msampathkumar msampathkumar added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2025
@msampathkumar msampathkumar merged commit 2ded410 into GoogleCloudPlatform:main Oct 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@msampathkumar msampathkumar msampathkumar approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /