Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add storage batch operations samples #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thiyaguk09 wants to merge 9 commits into GoogleCloudPlatform:main
base: main
Choose a base branch
Loading
from thiyaguk09:storagebatchoperations-samples

Conversation

@thiyaguk09
Copy link

@thiyaguk09 thiyaguk09 commented Sep 11, 2025

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 11, 2025
@thiyaguk09 thiyaguk09 force-pushed the storagebatchoperations-samples branch from e7476df to c1d08bd Compare September 12, 2025 07:52
@thiyaguk09 thiyaguk09 marked this pull request as ready for review September 12, 2025 09:52
Copy link

snippet-bot bot commented Sep 12, 2025 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@thiyaguk09 thiyaguk09 force-pushed the storagebatchoperations-samples branch from c1d08bd to b424e2c Compare September 22, 2025 08:15
Copy link
Author

@ddelgrosso1 Just a friendly reminder to review this PR when you get a chance. Thanks!

Copy link
Author

@ddelgrosso1 Could you please merge this PR if possible?

Copy link

@chandra-siri chandra-siri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a minor comment. Nothing blocking.

 

...on & Error Handling)
Improve the robustness and clarity of the Storage Batch Operations API
samples:
* **Error Handling:** Wraps all asynchronous Batch Operations API
samples (Create, Get, List, Cancel) in `try...catch` blocks for
production readiness.
* **Specific Diagnostics:** Adds specific gRPC error code checks
(`NOT_FOUND`, `FAILED_PRECONDITION`) within the `catch` blocks to
provide detailed diagnostic feedback to users regarding job state or
non-existence.
* **Documentation:** Clarifies JSDoc for all function parameters (e.g.,
`projectId`, `jobId`, `objectPrefix`), ensuring examples and types are
clear for developers.
@thiyaguk09 thiyaguk09 force-pushed the storagebatchoperations-samples branch from 6f5d870 to 7dceecc Compare October 24, 2025 06:51
Copy link
Contributor

Looks like Storage Intelligence is not enabled for the long-door-651 project. You will need to reach out to a member of the Cloud SDK Node team to get it enabled.
thiyaguk09 reacted with thumbs up emoji thiyaguk09 reacted with eyes emoji

Copy link
Author

@ddelgrosso1 Storage Intelligence permission has been enabled, and I am currently unable to run tests from my end. Could you please review it once?

Copy link
Author

@ddelgrosso1, @chandra-siri Could you please run the test cases again? I don't have permission to do so on my end. I have received confirmation that Storage Intelligence permission has been granted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chandra-siri chandra-siri chandra-siri approved these changes

@ddelgrosso1 ddelgrosso1 Awaiting requested review from ddelgrosso1

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /