Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: batch_create_gpu_job #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gryczj merged 2 commits into main from batch-create-gpu-job
Aug 6, 2024
Merged

feat: batch_create_gpu_job #3776

gryczj merged 2 commits into main from batch-create-gpu-job
Aug 6, 2024

Conversation

@gryczj
Copy link
Contributor

@gryczj gryczj commented Aug 5, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples. api: batch Issues related to the Batch API. labels Aug 5, 2024
@gryczj gryczj requested review from a team as code owners August 5, 2024 11:36
Copy link

snippet-bot bot commented Aug 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 5, 2024
@gryczj gryczj force-pushed the batch-create-gpu-job branch 2 times, most recently from 10f5e02 to 37f2b4c Compare August 5, 2024 12:07
'use strict';

async function main() {
// [START batch_create_gpu_job]
Copy link
Contributor

@m-strzelczyk m-strzelczyk Aug 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to have one more sample with batch_create_gpu_job_n1 region tag, to show how to use T4 and other GPUs that run on N1 platform.

Python version: https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/batch/create/create_with_gpu_no_mounting.py

Please add the N1 sample to this PR as well, as they're a "pair" :)

gryczj reacted with thumbs up emoji
@gryczj gryczj force-pushed the batch-create-gpu-job branch from da6c5b5 to c32c6f4 Compare August 6, 2024 11:39
@gryczj gryczj merged commit d27e2bf into main Aug 6, 2024
@gryczj gryczj deleted the batch-create-gpu-job branch August 6, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

No one assigned

Labels

api: batch Issues related to the Batch API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /