Implement unique title tags for sections & variants #3768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

zenoachtig wants to merge 1 commit into main

from zeno/rnd-8507-when-a-site-is-using-variants-for-versioning-implement

Open

Implement unique title tags for sections & variants #3768

zenoachtig wants to merge 1 commit into main from zeno/rnd-8507-when-a-site-is-using-variants-for-versioning-implement

Conversation

@zenoachtig

Copy link

Contributor

@zenoachtig zenoachtig commented Oct 28, 2025

No description provided.

@zenoachtig


 Implement unique title tags for sections & variants

4d23553

@linear

Copy link

linear bot commented Oct 28, 2025

RND-8507 When a site is using variants for versioning - Implement unique title tags

@changeset-bot

Copy link

changeset-bot bot commented Oct 28, 2025

🦋 Changeset detected

Latest commit: 4d23553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
gitbook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zenoachtig zenoachtig deployed to 2c-preview

October 28, 2025 12:47

— with GitHub Actions View deployment

@zenoachtig zenoachtig deployed to 2v-preview

October 28, 2025 12:47

— with GitHub Actions View deployment

@github-actions

Copy link

Contributor

github-actions bot commented Oct 28, 2025

Summary of the deployments:

Version	URL	Status
Vercel	https://gitbook-v2-mi51l7uk3-gitbook.vercel.app	✅
Cloudflare	https://0e022742-gitbook-open-v2-preview.gitbook.workers.dev	✅

Test content

Site	`2v`	`2c`
GitBook	https://gitbook-v2-mi51l7uk3-gitbook.vercel.app/url/gitbook.com/docs	https://0e022742-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.com/docs
E2E	https://gitbook-v2-mi51l7uk3-gitbook.vercel.app/url/gitbook.gitbook.io/test-gitbook-open	https://0e022742-gitbook-open-v2-preview.gitbook.workers.dev/url/gitbook.gitbook.io/test-gitbook-open

@argos-ci

Copy link

argos-ci bot commented Oct 28, 2025 •

edited

Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
customers-v2 (Inspect)	✅ No changes detected	-	Oct 28, 2025, 12:53 PM
v2-cloudflare (Inspect)	⚠️ Changes detected (Review)	1 changed	Oct 28, 2025, 12:56 PM
v2-vercel (Inspect)	⚠️ Changes detected (Review)	3 changed	Oct 28, 2025, 12:56 PM

gregberge

gregberge approved these changes

Oct 29, 2025

View reviewed changes

packages/gitbook/src/components/SitePage/SitePage.tsx

siteSpaces.length > 1 && // Only if there are multiple variants

siteSpaces.filter((space) => space.space.language === siteSpace.space.language).length >

1 && // Only if there are multiple variants *for the current language*. This filters out spaces that are "just" translations of each other, not versions.

siteSpace.default === false // Only if the variant is not the default one

Copy link

Contributor

@gregberge gregberge Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this first it's costless.

packages/gitbook/src/components/SitePage/SitePage.tsx

if (

sections &&

sections.list.filter((section) => section.object === 'site-section').length > 1 && // Only if there are multiple sections

sections.current.default === false // Only if the current section is not the default one

Copy link

Contributor

@gregberge gregberge Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put this first it's costless.

Labels

None yet

3 participants

@zenoachtig @gregberge

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement unique title tags for sections & variants #3768

Are you sure you want to change the base?

Implement unique title tags for sections & variants #3768

Uh oh!

Conversation

@zenoachtig zenoachtig commented Oct 28, 2025

Uh oh!

linear bot commented Oct 28, 2025

Uh oh!

changeset-bot bot commented Oct 28, 2025

🦋 Changeset detected

Uh oh!

github-actions bot commented Oct 28, 2025

Test content

Uh oh!

argos-ci bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

Uh oh!

@gregberge gregberge Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

@gregberge gregberge Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Implement unique title tags for sections & variants #3768

Are you sure you want to change the base?

Implement unique title tags for sections & variants #3768

Uh oh!

Conversation

@zenoachtig zenoachtig commented Oct 28, 2025

Uh oh!

linear bot commented Oct 28, 2025

Uh oh!

changeset-bot bot commented Oct 28, 2025

🦋 Changeset detected

Uh oh!

github-actions bot commented Oct 28, 2025

Test content

Uh oh!

argos-ci bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

@gregberge gregberge Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

@gregberge gregberge Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

argos-ci bot commented Oct 28, 2025 •

edited

Loading